[issue31174] test_tools leaks randomly references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor added the comment:

test_tools also fails on x86 Gentoo Refleaks 3.6:

http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.6/builds/90

test_tools leaked [1, 1, 118] memory blocks, sum=120
(...)
test_tools leaked [7, 1, 6] memory blocks, sum=14

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31174] test_tools leaks randomly references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor added the comment:

I created bpo-31227: "regrtest: reseed random with the same seed before running 
a test file".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31174] test_tools leaks randomly references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

Changes by STINNER Victor :


--
pull_requests: +3093

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31174] test_tools leaks randomly references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

New submission from STINNER Victor:

The "x86 Gentoo Refleaks 3.x" buildbot runs tests using -u-cpu to disable the 
cpu resource. The problem is that DirectoryTestCase.test_files() of 
Lib/test/test_tools/test_unparse.py uses random:

# Test limited subset of files unless the 'cpu' resource is specified.
if not test.support.is_resource_enabled("cpu"):
names = random.sample(names, 10)

So when we run the same test 7 times, each run uses different data.

I see different options:

* Reseed random using the same seed in dash_R() of regrtest
* Always test all data in test_unparse.py: all files, or select a specific set 
of interesting files

The random issue is more generic than just test_unparse.py, and so it would be 
interesting to explore this path. Maybe the random issue explains why some 
other tests fail randomly.

libregrtest always seeds the random RNG using a seed displayed on the standard 
output. We should either reuse this seed, or create a new unique seed for each 
test file, and display it (to be able to reproduce tests).

Reseed random before running each test file can also helps to make tests more 
reproductible

--

http://buildbot.python.org/all/builders/x86%20Gentoo%20Refleaks%203.x/builds/52/steps/test/logs/stdio

test_tools leaked [1, 4, 2] memory blocks, sum=7
(...)
Re-running test 'test_tools' in verbose mode
(...)
test_tools leaked [1, 2, 2] memory blocks, sum=5
(...)
1 test failed again:
test_tools

--
components: Tests
messages: 300075
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: test_tools leaks randomly references on x86 Gentoo Refleaks 3.x
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com