[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-30 Thread Serhiy Storchaka 

Changes by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-30 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:


New changeset 095a421b1606ee27e00a5d9d253b05a9f0cfadb8 by Serhiy Storchaka 
(Oren Milman) in branch '3.6':
[3.6] bpo-31291: Fixed an assertion failure in zipimport.zipimporter.get_data() 
(GH-3226) (#3243)
https://github.com/python/cpython/commit/095a421b1606ee27e00a5d9d253b05a9f0cfadb8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-30 Thread Oren Milman 

Changes by Oren Milman :


--
pull_requests: +3287

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-29 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:


New changeset 631fdee6e61b4ba8ce800f827fecdd536bfb04f3 by Serhiy Storchaka 
(Oren Milman) in branch 'master':
bpo-31291: Fixed an assertion failure in zipimport.zipimporter.get_data() 
(#3226)
https://github.com/python/cpython/commit/631fdee6e61b4ba8ce800f827fecdd536bfb04f3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-28 Thread Serhiy Storchaka 

Serhiy Storchaka added the comment:

Oren already fixed several similar problems and he is aware of difference 
between a crash and an exception.

The problem is Windows specific. The current code uses Unicode C API with the 
result of calling the replace method. This can cause a segfault (or may be an 
assertion failure in debug build).

The proposed solution LGTM. It undermines duck-typing, but I think this doesn't 
break any existing code. The duck-typing was not intentional and is 
Windows-only.

--
components: +Extension Modules -Interpreter Core
nosy: +serhiy.storchaka
stage:  -> patch review
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31291] zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

2017-08-28 Thread Brett Cannon 

Changes by Brett Cannon :


--
title: an assertion failure in zipimport.zipimporter.get_data() -> 
zipimport.zipimporter.get_data() crashes when path.replace() returns a non-str

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com