[issue31299] Add "ignore_modules" option to TracebackException.format()

[Irit Katriel]

Irit Katriel  added the comment:


New changeset 863154c9292e70c5a8a1a3f22ef4ee42e2304281 by Irit Katriel in 
branch 'main':
bpo-31299: make it possible to filter out frames from tracebacks (GH-28067)
https://github.com/python/cpython/commit/863154c9292e70c5a8a1a3f22ef4ee42e2304281


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +26511
pull_request: https://github.com/python/cpython/pull/28067

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Irit Katriel]

Change by Irit Katriel :


--
pull_requests: +25358
pull_request: https://github.com/python/cpython/pull/26772

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Irit Katriel]

Change by Irit Katriel :


--
versions: +Python 3.10 -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Irit Katriel]

Irit Katriel  added the comment:

In issue42247 the unit test framework uses limit as a hack to remove its own 
frame, and then the traceback module applies the limit to the chained exception 
as well.

If the filter suggested here existed, unit test could use that instead of limit.

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
nosy:  -vaultah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
pull_requests:  -11522

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
pull_requests:  -5065

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
pull_requests: +11522

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Dmitry Kazakov  added the comment:

It would seem no one is actually interested in this proposed enhancement. I'm 
closing my PR, since I'm not interested in resolving the file conflict. I'll 
probably submit a traceback-mutating patch to the issue 16217. This issue can 
be closed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


Removed file: https://bugs.python.org/file47284/traceback_filter.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Dmitry Kazakov  added the comment:

I asked for some input on this issue in January 
(https://mail.python.org/pipermail/python-dev/2018-January/151590.html). Since 
then an important PR was merged (https://github.com/python/cpython/pull/4793), 
however it mutates the traceback object. Should there be a way to hide frames 
while keeping the original traceback object intact? If not, this issue should 
probably be closed. Otherwise I would appreciate a review of the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
pull_requests: +5065
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I have prepared a patch (attached) with a possible implementation of the C 
function that can filter traceback objects modifying the traceback chain. I can 
make a PR if the patch looks good enough to start iterating over it. In case an 
alternative implementation is needed I am more than happy to prepare another 
patch/PR.

--
keywords: +patch
nosy: +pablogsal
Added file: https://bugs.python.org/file47284/traceback_filter.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Change by Dmitry Kazakov :


--
pull_requests:  -3274

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Dmitry Kazakov  added the comment:

I only recently realized that trace.Trace accepts two similar arguments, namely 
ignoremods and ignoredirs. Should we try to make the API and implementation of 
the functionality proposed here conform to that of trace.Trace's ignoremods? 
Would Python-Ideas be a more appropriate place to discuss this?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Dmitry Kazakov  added the comment:

Ping. (this issue needs a decision on ignore_modules vs filter callback, and/or 
patch review)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Dmitry Kazakov added the comment:

Yes, a public built-in facility to modify a traceback would certainly be 
useful, although there should be a standard way to "hide" unwanted frames 
without mutating the traceback, too, and the traceback module seems a perfect 
place to add it.

I have no objections to the `filter` argument, though filtering out frames 
based on modules to me feels by far more common a task than anything else 
`filter` would be capable of.

I can update the PR if there's a consensus that `filter` is favored over 
`ignore_modules`.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Antoine Pitrou]

Antoine Pitrou added the comment:

I think a more general facility to strip unwanted frames from traceback objects 
would be useful for more people (including importlib, I think).  i.e. actually 
mutate the traceback object, not remove the unwanted frames when printing 
(since it only works if you're the one doing the printing).

(note mutating a traceback object is very easy in C, it's just not possible in 
pure Python, except perhaps with nasty ctypes hacks)

Also, the `ignore_modules` would be more powerful as a generic `filter` 
callback, I think.

--
nosy: +brett.cannon, pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Dmitry Kazakov]

Changes by Dmitry Kazakov :


--
pull_requests: +3274

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31299] Add "ignore_modules" option to TracebackException.format()

[Nick Coghlan]

New submission from Nick Coghlan:

This is a proposed traceback module enhancement deriving from the "python -m" 
traceback verbosity discussion in issue 16217.

Specifically, I'm thinking a good way of cleaning up those tracebacks would be 
to use `TracebackException.format()` to get the formatted exception output, but 
designate particular modules to be *skipped* during the iteration (specifically 
`runpy`, `_frozen_importlib`, `importlib`).

I'm filing this as a separate issue so the discussion of the public API for the 
capability in the traceback module can be separated from the discussion of 
applying that API in runpy.

--
components: Library (Lib)
messages: 300974
nosy: ncoghlan, rbcollins, vaultah
priority: normal
severity: normal
stage: needs patch
status: open
title: Add "ignore_modules" option to TracebackException.format()
type: enhancement
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com