[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Erik Bray]

Erik Bray  added the comment:

Well, we'll see how long it takes me to get them to respond on that.  If it's 
not too much trouble then I'll be happy to drop this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

This is a problem of AppVeyor. It should update Cygwin to a bugfix release. 
2.8.0 contains other bugs.

--
resolution:  -> out of date
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Erik Bray]

Erik Bray  added the comment:

Well, I agree there's an unfortunate trade-off here: One can skip the test, 
allowing the test suite to work on slightly older versions of Cygwin, from 
before this issue was fixed.  However, I then lose regression testing on newer 
versions.  My personal feeling in this case is that it's not a very important 
test and can be skipped in the future (although the bug that this test caught 
was fairly serious and one would want regression testing for it...)

As an alternative I could be more fine-grained and only skip the test on older 
versions of Cygwin that are affected.  I was hoping to avoid putting in too 
much Cygwin-specific test utilities, though adding a version check for Cygwin 
is not terribly hard (I do the same for my Cygwin port of psutil).

For reference, the current version of Cygwin that comes installed on AppVeyor 
(for which I'm trying to get a Cygwin build set up) is 2.8.0, which *is* (just 
barely) affected by this bug.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

According to your reference a problem is fixed in recent Cygwin versions, isn't?

Skipping the test on Cygwin means that wcsxfrm() will be untested on this 
platform. Future regressions will be unnoticed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Erik Bray]

Erik Bray  added the comment:

To be clear, are you saying there shouldn't be a workaround to the underlying 
issue (I agree), or are you saying the test skip shouldn't even be added? I'm 
in favor of just skipping the test since it's still a problem on (currently) 
recent Cygwin versions. And it's not a very critical test so I'm happy to just 
skip it in this case.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Since this bug has been fixed in Cygwin, I don't think we should add a 
workaround for it. The expected date of Python 3.7 release is 2018-06-15, this 
is far from the date of releasing the fixed Cygwin.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Erik Bray]

Change by Erik Bray :


--
keywords: +patch
pull_requests: +4116
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31883] Cygwin: heap corruption bug in wcsxfrm

[Erik Bray]

New submission from Erik Bray :

There is an acknowledged bug in Cygwin's implementation of wcsxfrm() [1] that 
can cause heap corruption in certain cases.  This bug has since been fixed in 
Cygwin 2.8.1-1 [2] and all current and future releases.  However, that was 
relatively recent (July 2017) so it may still crop up.

I also have a workaround for this from the Python side, but rather than clutter 
the code with workarounds for platform-specific bugs I think it suffices just 
to skip the test in this case.

[1] https://cygwin.com/ml/cygwin/2017-05/msg00149.html
[2] https://cygwin.com/ml/cygwin-announce/2017-07/msg2.html

--
messages: 305120
nosy: erik.bray
priority: normal
severity: normal
status: open
title: Cygwin: heap corruption bug in wcsxfrm

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com