[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Stefan Krah]

Change by Stefan Krah :


--
assignee:  -> skrah
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> compile error

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Stefan Krah]

Stefan Krah  added the comment:


New changeset bd4ed77f73d37df325fc8f1e193b3ce6bc08094d by Stefan Krah in branch 
'master':
bpo-32233: Fix build with --with-system-libmpdec. (#4739)
https://github.com/python/cpython/commit/bd4ed77f73d37df325fc8f1e193b3ce6bc08094d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Stefan Krah]

Change by Stefan Krah :


--
pull_requests: +4642
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Stefan Krah]

Stefan Krah  added the comment:

I suggest to restore the logic from 75c0d4f6bb97e723adc3a03c0ff6aaaee0c6981a .

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Stefan Krah]

Stefan Krah  added the comment:

At some point linking explicitly against libm was added. The build
still worked until 8acaa31eec removed detect_math_libs().

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Ned Deily]

Change by Ned Deily :


--
nosy: +ned.deily
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[STINNER Victor]

Change by STINNER Victor :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Matthias Klose]

Matthias Klose  added the comment:

proposed patch, however I don't know the rationale for that change compared to 
3.7alpha2.

--
keywords: +patch
Added file: https://bugs.python.org/file47324/issue32233.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32233] [3.7 Regression] build with --with-system-libmpdec is broken

[Matthias Klose]

New submission from Matthias Klose :

in setup.py, for the _decimal module the libararies are now set exclusively to 
['m'], without checking if this is really needed, and overriding the external 
mpdec library, breaking the build.  Is there any reason to override that?

--
components: Build
messages: 307738
nosy: doko
priority: normal
severity: normal
status: open
title: [3.7 Regression] build with --with-system-libmpdec is broken
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com