[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Steve Dower]

Steve Dower  added the comment:

I'm going to just close this without fixing 3.5. If there's demand, we can 
consider it, but at this stage it's so easy for people to migrate to 3.6 or 
later that I'm sure that's already been done.

--
resolution:  -> fixed
stage: backport needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Berker Peksag]

Berker Peksag  added the comment:

It looks like we need to backport this manually for 3.5 (if Larry approves)

--
stage: patch review -> backport needed
versions:  -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 09eb6fe8fdd2515546b933902aef36b72d417ace by Berker Peksag (Miss 
Islington (bot)) in branch '3.6':
bpo-32282: Remove unnecessary check for `VersionHelpers.h` in `socketmodule.c` 
on Windows (GH-5120)
https://github.com/python/cpython/commit/09eb6fe8fdd2515546b933902aef36b72d417ace


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Roundup Robot]

Change by Roundup Robot :


--
pull_requests: +4987

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Steve Dower]

Steve Dower  added the comment:


New changeset af11a15c586e980a157c04ee60b6e33dc7228f3f by Steve Dower (Max 
Bélanger) in branch 'master':
bpo-32282: Remove unnecessary check for `VersionHelpers.h` in `socketmodule.c` 
on Windows
https://github.com/python/cpython/commit/af11a15c586e980a157c04ee60b6e33dc7228f3f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Maxime Belanger]

Maxime Belanger  added the comment:

Works for me. We no longer rely on the `_xp` toolset so no objections.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Steve Dower]

Steve Dower  added the comment:

If you can't compile, security fixes aren't worth anything. And while we don't 
support XP, the v140_xp toolset is in more of a grey area. There are real ways 
you could be forced into using it besides targeting XP.

Max - I'd rather just remove the ifdef checks completely. Fairly sure I added 
them in the migration from VC10, but they are simply incorrect (the header is 
from the WinSDK which is not the same as _MSC_VER) and will always be there for 
the versions of the SDK we allow, even back to 3.5.

--
nosy: +larry
type:  -> compile error
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Christian Heimes]

Christian Heimes  added the comment:

- 3.5 receives only security updates.
- XP is no longer supported.

--
assignee:  -> steve.dower
nosy: +christian.heimes
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Max Bélanger]

Change by Max Bélanger :


--
keywords: +patch
pull_requests: +4702
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32282] When using a Windows XP compatible toolset, `socketmodule.c` fails to build

[Maxime Belanger]

New submission from Maxime Belanger :

If Python is built using the Windows XP "variant" of the toolset (e.g. 
`v140_xp`), build errors can occur in `socketmodule.c`. This is due to the 
include of `VersionHelpers.h` being gated on `_MSC_VER`, which "lies" if 
`v140_xp` is in use.

We'll be contributing our patch to this issue here.

--
components: Windows
messages: 308081
nosy: Maxime Belanger, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: When using a Windows XP compatible toolset, `socketmodule.c` fails to 
build
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com