[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Steve Dower  added the comment:

Missed the a4 cutoff, but it'll be in 3.7.0b1.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Steve Dower  added the comment:


New changeset d135f20ae8887acc7716561bc8f4c7eb6d58d24c by Steve Dower in branch 
'master':
bpo-32507: Change Windows install to include app-local UCRT (#5119)
https://github.com/python/cpython/commit/d135f20ae8887acc7716561bc8f4c7eb6d58d24c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Steve Dower  added the comment:

All correct. I believe venv is fine, as it copies all DLLs, but virtualenv is 
more selective and will need to be updated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Paul Moore]

Paul Moore  added the comment:

Oh, so we're talking here about bundling the ucrt installers and then if the 
user doesn't already have ucrt installed system wide, we will install a local 
copy, but if they do, we don't do anything? If we install a local copy, then 
it'll be used until the user installs a system copy, at which point the local 
copy remains but gets ignored, correct? That seems OK, although I can see a 
local copy that's not used being confusing - but it's for very few users so no 
real issue.

I'm not sure what you're saying for venv/virtualenv though? Presumably they 
will need to copy the local copy if it's present, but that local copy will be 
ignored if there's a system copy?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Steve Dower  added the comment:

Technically yes, though I think at this stage it will be very few machines that 
end up with our copy, and users can patch their own system using Windows Update 
even if we've installed a copy. Particularly for our user base, where I suspect 
most pre-Win10 Python users will have installed 3.5 or 3.6 previously and so 
have the proper update.

There should be very few first time Python users on older operating systems, 
and it will approach zero over time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Paul Moore]

Paul Moore  added the comment:

Does this mean that we'll need to update the bundled ucrt whenever there are 
security patches to the baseline version? Are we happy with the security 
implications of that?

I thought one of the key advantages of using the system CRT (whether the old 
msvcrXX.dll or the new ucrt) was that we automatically received security 
patches.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Steve Dower  added the comment:

The PR is ready, but I'll leave this open for a few days in case anyone wants 
to comment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +4984
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch, patch
pull_requests: +4984, 4985
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32507] Change Windows install to applocal UCRT

[Steve Dower]

New submission from Steve Dower :

There's enough instability due to using the proper UCRT installer (e.g. 
issue25546, issue25954, also others not reported on bpo) and good enough 
install base that we can simplify things by just installing it locally on 
machines that require it.

This may also require updating venv (though I think we're fine) and virtualenv 
(I'll ping).

My proposal is to bundle the UCRT redistributable DLLs into their own MSI and 
install them alongside the main executable when required. If a user later 
installs it properly, the up-to-date version will be used instead. This should 
be good enough to cover people still on Windows 7/8, and will also reduce the 
installer size slightly (though at the cost of potentially breaking 
non-standard virtual environments or entrypoint stubs that link to the CRT 
dynamically).

--
assignee: steve.dower
components: Windows
messages: 309589
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: Change Windows install to applocal UCRT
type: enhancement
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com