[issue32838] Fix Python versions in the table of magic numbers

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[miss-islington]

miss-islington  added the comment:


New changeset 8d9d4b57ae57baee4401cab6067ef22c0172661d by Miss Islington (bot) 
in branch '3.7':
bpo-32838: Fix Python versions in the table of magic numbers. (GH-5658)
https://github.com/python/cpython/commit/8d9d4b57ae57baee4401cab6067ef22c0172661d


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[miss-islington]

Change by miss-islington :


--
pull_requests: +5595

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 4af8fd561433826ac897c55e41a087a5c5dbacf3 by Serhiy Storchaka in 
branch 'master':
bpo-32838: Fix Python versions in the table of magic numbers. (#5658)
https://github.com/python/cpython/commit/4af8fd561433826ac897c55e41a087a5c5dbacf3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I think it is useful to have such table somewhere. It give the impression about 
the history of bytecode and pyc format. There are third-party projects that try 
to support Python bytecode of different versions, they need such table. There 
is a simplified version of this table in PC/launcher.c, it is needed for 
suggesting the Python version by the magic number. And this table is just 
interesting for Python developers, especially if they made the change in the 
bytecode.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[Benjamin Peterson]

Benjamin Peterson  added the comment:

Maybe we should simply delete this comment? I'm not sure how useful it is.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +5460
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32838] Fix Python versions in the table of magic numbers

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

All changes to the magic number in Lib/importlib/_bootstrap_external.py are 
attributed with 3.7a0. But they were made at different stages.

There is also inconsistency in specifying Python version for older changes. 
Some authors specify the first Python version after bumping the magic number 
(i.e. the version that was released with this magic number). Others specify the 
Python version after which the bumping was made. I think the former is correct.

The proposed PR fixes Python versions and adds issue numbers if known. I have 
tracked only changes in Python 3.x.

--
messages: 312115
nosy: benjamin.peterson, pitrou, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Fix Python versions in the table of magic numbers
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com