[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Josh Friend]

Josh Friend  added the comment:

yes it should be closed, can i do that? (ill try...)

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Irit Katriel]

Irit Katriel  added the comment:

This seems resolved, can it be closed?

--
nosy: +iritkatriel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 5bf74859fe253f0e8ff73ba699cd1a7e2dfbcea3 by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-32922: dbm.open() now encodes filename with the filesystem encoding. 
(GH-5832). (GH-5906)
https://github.com/python/cpython/commit/5bf74859fe253f0e8ff73ba699cd1a7e2dfbcea3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +5677

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[miss-islington]

miss-islington  added the comment:


New changeset a9e0b070b3e36701d0139361c769d374c4aacf1a by Miss Islington (bot) 
in branch '3.7':
bpo-32922: dbm.open() now encodes filename with the filesystem encoding. 
(GH-5832)
https://github.com/python/cpython/commit/a9e0b070b3e36701d0139361c769d374c4aacf1a


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[miss-islington]

Change by miss-islington :


--
pull_requests: +5676

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 6f600ff1734ca2fdcdd37a809adf8130f0d8cc4e by Serhiy Storchaka in 
branch 'master':
bpo-32922: dbm.open() now encodes filename with the filesystem encoding. 
(GH-5832)
https://github.com/python/cpython/commit/6f600ff1734ca2fdcdd37a809adf8130f0d8cc4e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Armin Rigo]

Armin Rigo  added the comment:

It's not a new feature.  See for example all functions from posixmodule.c: it 
should at least be PyArg_ParseTuple(args, "et", Py_FileSystemDefaultEncoding, 
_star_variable).

--
nosy: +arigo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

PR 5832 fixes dbm.ndbm.open() and dbm.gdbm.open(). dbm.dumb.open() already used 
the filesystem encoding.

I don't think anything should be fixed in 2.7. Supporting Unicode filenames 
looks like a new feature.

--
versions: +Python 3.7, Python 3.8 -Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +5610
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32922] dbm.open() encodes filename with default encoding rather than the filesystem encoding

[Josh Friend]

New submission from Josh Friend :

Armin Rigo from the PyPy project pointed this out to me: 
https://bitbucket.org/pypy/pypy/issues/2755/dbmopen-expects-a-str-for-filename-throws

This could probably lead to some weird behavior given the right filename

--
components: Library (Lib)
messages: 312636
nosy: Josh Friend
priority: normal
severity: normal
status: open
title: dbm.open() encodes filename with default encoding rather than the 
filesystem encoding
type: behavior
versions: Python 2.7, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com