[issue33051] IDLE: Create new tab for editor options in configdialog

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder:  -> IDLE: configdialog tab rearrange

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Mark Roseman]

Change by Mark Roseman :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Cheryl Sabella]

Cheryl Sabella  added the comment:

@epaine, thank you for taking a look at that PR and for your feedback.  I agree 
with you that the changes can still be taken further than we've already done.  
`init_validators` was added after the initial refactoring and I'm not sure if 
we've gone back to it to really use it or any other input validators.  There's 
another bug issue (#31306) that addresses the validation on configdialog, so 
maybe your ideas can be incorporated with that issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[E. Paine]

E. Paine  added the comment:

Thank you Cheryl for linking this issue on #40468 (I didn't find this when 
researching for existing issues). I have briefly tested the PR and it seems 
perfect, though seeing `init_validators` made me think we should possibly have 
an ABC for the tab pages. This would be a separate issue, but I think there 
would be three main advantages:
1. We could enforce a more standard naming of page methods (`create_page_*` 
would become `create_page` and be called by the parent, for example)
2. We could share methods like `init_validators` (which would preferably be 
part of the class but I appreciate the need to move it in this PR)
3. We can also potentially remove the example `TabPage` as the ABC would serve 
as its own example

Back to this issue, I didn't scrutinise it but the PR looks good and the 
"result" (user-facing) is exactly as I would propose based on #40468.

--
nosy: +epaine
versions: +Python 3.10, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Terry J. Reedy]

Terry J. Reedy  added the comment:

A new option would (maybe) apply to saving the shell also.  (Something to 
discuss there.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Cheryl Sabella]

Cheryl Sabella  added the comment:

Yes, I thought it would be good to have this before issue33046.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I expected that this would be needed eventually.  Any particular reason why now?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +patch
pull_requests: +5843
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33051] IDLE: Create new tab for editor options in configdialog

[Cheryl Sabella]

New submission from Cheryl Sabella :

Split out editor options from general tab in Config Dialog.

--
assignee: terry.reedy
components: IDLE
messages: 313618
nosy: csabella, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Create new tab for editor options in configdialog
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com