[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Change by Łukasz Langa :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +5864
stage: commit review -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 6a526f673878677032c02f7800ee13d4769f391a by Łukasz Langa (Miss 
Islington (bot)) in branch '3.6':
bpo-33064: lib2to3: support trailing comma after *args and **kwargs (GH-6096) 
(#6098)
https://github.com/python/cpython/commit/6a526f673878677032c02f7800ee13d4769f391a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset b4c8871ca43d37be167ef5dbe9fb341922c04a9f by Łukasz Langa (Miss 
Islington (bot)) in branch '3.7':
bpo-33064: lib2to3: support trailing comma after *args and **kwargs (GH-6096) 
(#6097)
https://github.com/python/cpython/commit/b4c8871ca43d37be167ef5dbe9fb341922c04a9f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:

Oh, and in terms of *calling* functions, now we can specify multiple unpacks, 
like:

  >>> f(
  ...   **d,
  ...   **e,
  ... )

so the extra comma for signatures simply makes it symmetrical in terms of 
appearance.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:

Yes, this ship has sailed with Python 3.6.

I understand your logic and this is indeed why we didn't support this for a 
long time. However, people tend to grow muscle memory to add trailing commas 
and that was tripping them over for no real gain on our part. So this was 
added. The reason I found out about lib2to3 not following suit was that 3.6 
users quickly started to put those trailing commas in and tools using lib2to3 
were crashing on such files :) This proves it was worth it.

--
resolution:  -> fixed
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[miss-islington]

Change by miss-islington :


--
pull_requests: +5861

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[miss-islington]

Change by miss-islington :


--
pull_requests: +5860

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset b51f5de71163f096d2d5229ede5379cdb284f651 by Łukasz Langa in 
branch 'master':
bpo-33064: lib2to3: support trailing comma after *args and **kwargs (#6096)
https://github.com/python/cpython/commit/b51f5de71163f096d2d5229ede5379cdb284f651


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I'm not sure that a trailing comma after **kwargs in a function signature 
should be allowed in Python grammar. Reasons for allowing it after other 
arguments don't work here since **kwargs is always a last item in a signature.

But this ship perhaps is sailed.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Does it support a trailing comma after *args or name=value?

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Change by Łukasz Langa :


--
keywords: +patch, patch
pull_requests: +5858, 5859

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Change by Łukasz Langa :


--
keywords: +patch
pull_requests: +5858

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

Łukasz Langa  added the comment:

Ned, I'd like this to make into 3.6.5 if at all possible.

--
nosy: +ned.deily
stage:  -> patch review
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33064] lib2to3 fails on a trailing comma after **kwargs in a function signature

[Łukasz Langa]

New submission from Łukasz Langa :

Title says all. I have a patch.

--
assignee: lukasz.langa
messages: 313718
nosy: lukasz.langa
priority: normal
severity: normal
status: open
title: lib2to3 fails on a trailing comma after **kwargs in a function signature
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com