[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

[Berker Peksag]

Berker Peksag  added the comment:

Thanks for the PR, but we usually avoid unnecessary churn in Python codebase.

Both versions look fine, and deciding which one to use is just a matter of 
personal taste.

--
components:  -Windows
nosy: +berker.peksag -paul.moore, steve.dower, tim.golden, zach.ware
resolution:  -> rejected
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

[Ekin Dursun]

Change by Ekin Dursun :


--
keywords: +patch
pull_requests: +6002
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33161] Refactor of pathlib's _WindowsBehavior.gethomedir

[Ekin Dursun]

New submission from Ekin Dursun :

At line 245, default value for drv is provided with KeyError handling, but it 
is better to use dict's get method.

--
components: Library (Lib), Windows
messages: 314562
nosy: onlined, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Refactor of pathlib's _WindowsBehavior.gethomedir
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com