[issue33454] Mismatched C function signature in _xxsubinterpreters.channel_close()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33454] Mismatched C function signature in _xxsubinterpreters.channel_close()

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset d8dcd57edb88ce57063e5c2b85fe0ee1abb1ce8b by Serhiy Storchaka in 
branch 'master':
bpo-33454: Fix arguments parsing in _xxsubinterpreters.channel_close(). 
(GH-6747)
https://github.com/python/cpython/commit/d8dcd57edb88ce57063e5c2b85fe0ee1abb1ce8b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33454] Mismatched C function signature in _xxsubinterpreters.channel_close()

[Eric Snow]

Eric Snow  added the comment:

Thanks for catching this, Serhiy!  I've approved the PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33454] Mismatched C function signature in _xxsubinterpreters.channel_close()

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +6435
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33454] Mismatched C function signature in _xxsubinterpreters.channel_close()

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

The C function that implements _xxsubinterpreters.channel_close() is defined 
with the signature

PyObject *channel_close(PyObject *self, PyObject *args, PyObject *kwds)

which corresponds the method convention METH_VARARGS | METH_KEYWORDS, but is 
used with the incompatible method convention METH_VARARGS. Either the signature 
or flags are not correct.

Actually it can use just METH_O. The proposed PR changes both signature and 
flags and simplifies the implementation.

The bug was found thanks to gcc 8 emitting a warning for invalid function cast 
(it also emits a lot of false alarms). See also issue33012.

--
components: Extension Modules
messages: 316354
nosy: eric.snow, serhiy.storchaka, siddhesh
priority: normal
severity: normal
status: open
title: Mismatched C function signature in _xxsubinterpreters.channel_close()
type: behavior
versions: Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com