[issue33802] Regression in logging configuration

[Kyle Evans]

Change by Kyle Evans :


--
nosy: +kevans
nosy_count: 8.0 -> 9.0
pull_requests: +21629
pull_request: https://github.com/python/cpython/pull/22651

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Andrés Delfino]

Change by Andrés Delfino :


--
nosy:  -adelfino

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Stefan Behnel]

Change by Stefan Behnel :


--
nosy:  -scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Stefan Behnel]

Change by Stefan Behnel :


--
pull_requests:  -21521

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Stefan Behnel]

Change by Stefan Behnel :


--
nosy: +scoder
nosy_count: 9.0 -> 10.0
pull_requests: +21521
pull_request: https://github.com/python/cpython/pull/22474

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Andrés Delfino]

Change by Andrés Delfino :


--
nosy: +adelfino
nosy_count: 8.0 -> 9.0
pull_requests: +21317
pull_request: https://github.com/python/cpython/pull/22205

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[mohamed koubaa]

Change by mohamed koubaa :


--
nosy: +koubaa
nosy_count: 7.0 -> 8.0
pull_requests: +21220
pull_request: https://github.com/python/cpython/pull/21986

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Jakub Kulik]

Change by Jakub Kulik :


--
nosy:  -kulikjak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Jakub Kulik]

Change by Jakub Kulik :


--
pull_requests:  -21199

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Jakub Kulik]

Change by Jakub Kulik :


--
nosy: +kulikjak
nosy_count: 7.0 -> 8.0
pull_requests: +21199
pull_request: https://github.com/python/cpython/pull/22040

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Raymond Hettinger]

Change by Raymond Hettinger :


--
nosy: +rhettinger
nosy_count: 6.0 -> 7.0
pull_requests: +21112
pull_request: https://github.com/python/cpython/pull/21994

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Łukasz Langa]

Łukasz Langa  added the comment:

None is an invalid value in the configparser. It only accepts strings. See:

>>> cp = ConfigParser()
>>> cp['asd'] = {'a': None}
Traceback (most recent call last):
...
TypeError: option values must be strings



The DEFAULT section was an omission which is now fixed. You can use a 
RawConfigParser if you want to put invalid types as option values:

>>> rcp = RawConfigParser()
>>> rcp['asd'] = {'a': None}
>>>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Steap]

Steap  added the comment:

It seems like this regression has not completely been fixed: there are still 
issues with "None":

$ python3.6 -c 'import configparser; configparser.ConfigParser(defaults={"a": 
None})'

$ python3.7 -c 'import configparser; configparser.ConfigParser(defaults={"a": 
1})'

$ python3.7 -c 'import configparser; configparser.ConfigParser(defaults={"a": 
None})'
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib/python3.7/configparser.py", line 638, in __init__
self._read_defaults(defaults)
  File "/usr/lib/python3.7/configparser.py", line 1216, in _read_defaults
self.read_dict({self.default_section: defaults})
  File "/usr/lib/python3.7/configparser.py", line 753, in read_dict
self.set(section, key, value)
  File "/usr/lib/python3.7/configparser.py", line 1197, in set
self._validate_value_types(option=option, value=value)
  File "/usr/lib/python3.7/configparser.py", line 1182, in _validate_value_types
raise TypeError("option values must be strings")
TypeError: option values must be strings

Should "None" not be used, or should this bug be reopened?

--
nosy: +Steap

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[miss-islington]

miss-islington  added the comment:


New changeset f44203d782e397941c17d96e6a1f9dc1df08b3e6 by Miss Islington (bot) 
in branch '3.7':
bpo-33802: Do not interpolate in ConfigParser while reading defaults (GH-7524)
https://github.com/python/cpython/commit/f44203d782e397941c17d96e6a1f9dc1df08b3e6


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[miss-islington]

Change by miss-islington :


--
pull_requests: +7164

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Łukasz Langa]

Łukasz Langa  added the comment:


New changeset 214f18e49feb6a9d6c05aa09a4bb304905e81334 by Łukasz Langa in 
branch 'master':
bpo-33802: Do not interpolate in ConfigParser while reading defaults (GH-7524)
https://github.com/python/cpython/commit/214f18e49feb6a9d6c05aa09a4bb304905e81334


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Vinay Sajip]

Change by Vinay Sajip :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Łukasz Langa]

Łukasz Langa  added the comment:

I'm very sorry for the trouble! And impressed at Barry's quick diagnosis.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Łukasz Langa]

Change by Łukasz Langa :


--
pull_requests: +7152

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Ned Deily]

Change by Ned Deily :


--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
keywords: +patch
pull_requests: +7137
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Barry A. Warsaw]

Barry A. Warsaw  added the comment:

I think the regression is caused by the fix for bpo-23835

https://bugs.python.org/issue23835

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33802] Regression in logging configuration

[Barry A. Warsaw]

New submission from Barry A. Warsaw :

This looks like a serious regression in 3.7.  @ned.deily - I'm marking this as 
a release blocker, but feel free of course to downgrade it.

Run the following as

$ python3.6 badconfig.py
Hey, it works!

$ python3.7 badconfig.py
Traceback (most recent call last):
  File "../badconfig.py", line 77, in 
fileConfig(inifile.name, defaults=GUNICORN_DEFAULTS)
  File "/Users/barry/projects/python/cpython/Lib/logging/config.py", line 65, 
in fileConfig
cp = configparser.ConfigParser(defaults)
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 639, in 
__init__
self._read_defaults(defaults)
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 1212, 
in _read_defaults
self.read_dict({self.default_section: defaults})
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 754, in 
read_dict
self.set(section, key, value)
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 1200, 
in set
super().set(section, option, value)
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 895, in 
set
value)
  File "/Users/barry/projects/python/cpython/Lib/configparser.py", line 403, in 
before_set
"position %d" % (value, tmp_value.find('%')))
ValueError: invalid interpolation syntax in "{'generic': {'format': 
'%(asctime)s [%(process)d] [%(levelname)s] %(message)s', 'datefmt': '[%Y-%m-%d 
%H:%M:%S %z]', 'class': 'logging.Formatter'}}" at position 26

I'm still investigating, but wanted to get the bug filed asap.

--
assignee: barry
files: badconfig.py
keywords: 3.7regression
messages: 318980
nosy: barry, ned.deily
priority: release blocker
severity: normal
stage: needs patch
status: open
title: Regression in logging configuration
type: behavior
versions: Python 3.7, Python 3.8
Added file: https://bugs.python.org/file47635/badconfig.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com