[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The bots occasionally miss.
PR 7885 was indeed merged even though the message has not appeared.
https://github.com/python/cpython/commit/2c11e23a5a686edc69bcbb4c65f500d50d992bb3
PR 7886 was merged as the message says, even though the status was not changed.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Senthil Kumaran]

Senthil Kumaran  added the comment:


New changeset 0ba9a0b7d19da8b4bd3c13b358d3fd2a5ad16f09 by Senthil Kumaran 
(Andrés Delfino) in branch 'master':
[master] bpo-33885: Replace "hook function" with "callable" (GH-7765) (#7886)
https://github.com/python/cpython/commit/0ba9a0b7d19da8b4bd3c13b358d3fd2a5ad16f09


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Andrés Delfino]

Change by Andrés Delfino :


--
pull_requests: +7495

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Andrés Delfino]

Change by Andrés Delfino :


--
pull_requests: +7494

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[miss-islington]

miss-islington  added the comment:


New changeset e4db73058b6c31f71c64d0f87a10547f3cf72f20 by Miss Islington (bot) 
in branch '3.7':
bpo-33885: Replace "hook function" with "callable" (GH-7765)
https://github.com/python/cpython/commit/e4db73058b6c31f71c64d0f87a10547f3cf72f20


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[miss-islington]

Change by miss-islington :


--
pull_requests: +7471

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset c45cb479074b5d25f0d382d3109f527520a9f03c by Terry Jan Reedy 
(Andrés Delfino) in branch '3.6':
bpo-33885: Replace "hook function" with "callable" (GH-7765)
https://github.com/python/cpython/commit/c45cb479074b5d25f0d382d3109f527520a9f03c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Senthil Kumaran]

Senthil Kumaran  added the comment:

@Terry, the change in terminology looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Terry J. Reedy]

Terry J. Reedy  added the comment:

I am not even sure what a 'hook function' is supposed to mean.  A beginner 
might think it means something other than any old callable.  Unless Sentil or 
someone objects within a week, I would merge this.  Ping me if nothing happens.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Ned Deily]

Change by Ned Deily :


--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Andrés Delfino]

Change by Andrés Delfino :


--
keywords: +patch
pull_requests: +7373
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue33885] doc Replace "hook function" with "callable" in urllib.request.urlretrieve

[Andrés Delfino]

New submission from Andrés Delfino :

The reporthook of urllib.request.urlretrieve is treated as a function hook, 
while the right term is "callable".

PR fixes this.

--
assignee: docs@python
components: Documentation
messages: 319822
nosy: adelfino, docs@python
priority: normal
severity: normal
status: open
title: doc Replace "hook function" with "callable" in urllib.request.urlretrieve
type: enhancement
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com