[issue34080] Memory leak in the compiler in case of errors

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Serhiy for the fix! It seems that new tests helped to find a real bug ;-)

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 3b06285d2b7963d9d06b60e85712d5ecc6540deb by Victor Stinner (Miss 
Islington (bot)) in branch '3.6':
bpo-34080: Fix a memory leak in the compiler. (GH-8222) (GH-8257)
https://github.com/python/cpython/commit/3b06285d2b7963d9d06b60e85712d5ecc6540deb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[miss-islington]

miss-islington  added the comment:


New changeset 9beed0c36f4ce990ded095575ba3124e2264dbbe by Miss Islington (bot) 
in branch '3.7':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
https://github.com/python/cpython/commit/9beed0c36f4ce990ded095575ba3124e2264dbbe


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[miss-islington]

miss-islington  added the comment:


New changeset a45fa39d85fc500d530d05d3ec7b36eb5d286f5e by Miss Islington (bot) 
in branch '2.7':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
https://github.com/python/cpython/commit/a45fa39d85fc500d530d05d3ec7b36eb5d286f5e


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[miss-islington]

Change by miss-islington :


--
pull_requests: +7791

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[miss-islington]

Change by miss-islington :


--
pull_requests: +7790

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[miss-islington]

Change by miss-islington :


--
pull_requests: +7789

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 993030aac576710a46b3dd0b4864f819d4a94145 by Victor Stinner 
(Serhiy Storchaka) in branch 'master':
bpo-34080: Fix a memory leak in the compiler. (GH-8222)
https://github.com/python/cpython/commit/993030aac576710a46b3dd0b4864f819d4a94145


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[STINNER Victor]

STINNER Victor  added the comment:

Related issue: bpo-34084.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +7774

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +7760
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34080] Memory leak in the compiler in case of errors

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

Merging PR 6517 for issue33305 exposed a leak in the compiler:

https://buildbot.python.org/all/#/builders/1/builds/280

$ ./python -m test -R 3:3 test_compile test_grammar
Run tests sequentially
0:00:00 load avg: 1.95 [1/2] test_compile
beginning 6 repetitions
123456
..
test_compile leaked [15, 16, 15] memory blocks, sum=46
0:00:14 load avg: 1.97 [2/2/1] test_grammar -- test_compile failed
beginning 6 repetitions
123456
..
test_grammar leaked [50, 50, 50] memory blocks, sum=150
test_grammar failed

== Tests result: FAILURE ==

2 tests failed:
test_compile test_grammar

Total duration: 15 sec 226 ms
Tests result: FAILURE


This branch was not common, but after issue33305 it has became more common and 
heavily tested.

--
assignee: serhiy.storchaka
components: Interpreter Core
messages: 321367
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: Memory leak in the compiler in case of errors
type: resource usage
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com