[issue34319] Clarify pathlib.Path("filepath").read_text()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

Marking this bug as fixed via https://github.com/python/cpython/pull/8645

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[miss-islington]

miss-islington  added the comment:


New changeset 3da5c5c76d90ddfc4c188cc801d9387501b63b7f by Miss Islington (bot) 
in branch '3.6':
bpo-34319: Clarify file handler closure in pathlib.read_text (GH-8645)
https://github.com/python/cpython/commit/3da5c5c76d90ddfc4c188cc801d9387501b63b7f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[miss-islington]

miss-islington  added the comment:


New changeset 1c6df83e9318ab4ef8e32b805b8226b1324e1ffd by Miss Islington (bot) 
in branch '3.7':
bpo-34319: Clarify file handler closure in pathlib.read_text (GH-8645)
https://github.com/python/cpython/commit/1c6df83e9318ab4ef8e32b805b8226b1324e1ffd


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8188

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[miss-islington]

Change by miss-islington :


--
pull_requests: +8189

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset 5b2657fb8c5aaa98e5748e1c325c74b97ea12fd1 by Terry Jan Reedy 
(Xtreak) in branch 'master':
bpo-34319: Clarify file handler closure in pathlib.read_text (GH-8645)
https://github.com/python/cpython/commit/5b2657fb8c5aaa98e5748e1c325c74b97ea12fd1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Sanyam Khurana]

Sanyam Khurana  added the comment:

+1 to Terry's suggestion.

I've reviewed xtreak's PR and it looks good to me.

--
nosy: +CuriousLearner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Thomas Nyberg]

Thomas Nyberg  added the comment:

For what it's worth as the original opener of the bug report, I think Terry's 
recommendation clarifies things quite well.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
keywords: +patch
pull_requests: +8148
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Terry J. Reedy]

Terry J. Reedy  added the comment:

How about if we add "The file is opened and then closed." before "The optional 
parameters have the same meaning as in open()."

--
nosy: +terry.reedy
stage:  -> needs patch
versions: +Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34319] Clarify pathlib.Path("filepath").read_text()

[Thomas Nyberg]

New submission from Thomas Nyberg :

This came out of the following posts:

https://mail.python.org/pipermail/python-ideas/2018-August/052549.html
https://mail.python.org/pipermail/python-ideas/2018-August/052553.html

Basically my request would be to change the documentation here:

https://docs.python.org/3.7/library/pathlib.html#pathlib.Path.read_text

I would like to add a note that the underlying file object itself is closed 
after the read_text() method is called. Maybe I'm just a little dense and it 
should be obvious that the functionality here would be different than 
open("filepath").read(), but given that thread I linked, I don't believe I'm 
the only one.

--
assignee: docs@python
components: Documentation
messages: 322947
nosy: docs@python, thomas.nyberg
priority: normal
severity: normal
status: open
title: Clarify pathlib.Path("filepath").read_text()

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com