[issue34555] AF_VSOCK not unset because of wrong nesting

[miss-islington]

miss-islington  added the comment:


New changeset 4c532da1209bd20ba07f18448134f32ace8c54f7 by Miss Islington (bot) 
in branch '3.7':
closes bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H 
(GH-9016)
https://github.com/python/cpython/commit/4c532da1209bd20ba07f18448134f32ace8c54f7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34555] AF_VSOCK not unset because of wrong nesting

[miss-islington]

Change by miss-islington :


--
pull_requests: +8495

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34555] AF_VSOCK not unset because of wrong nesting

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 2d7102e726e973ab2d307aa9748c7ec433677877 by Benjamin Peterson 
(Thomas Herzog) in branch 'master':
closes bpo-34555: Fix incorrectly nested test for HAVE_LINUX_VM_SOCKETS_H 
(GH-9016)
https://github.com/python/cpython/commit/2d7102e726e973ab2d307aa9748c7ec433677877


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34555] AF_VSOCK not unset because of wrong nesting

[Thomas Herzog]

Change by Thomas Herzog :


--
keywords: +patch
pull_requests: +8484
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34555] AF_VSOCK not unset because of wrong nesting

[Thomas Herzog]

New submission from Thomas Herzog :

If ./configure runs with the following result...

checking for linux/vm_sockets.h... no
checking for sockaddr_alg... no

...then the result of the first check is treated as if it was "yes". This is 
because the logic for disabling the vm_sockets functionality is nested inside 
an #ifdef HAVE_SOCKADDR_ALG.

This leads to compilation errors:

In file included from ./Modules/socketmodule.c:283:0:
./Modules/socketmodule.h:206:24: error: field ‘vm’ has incomplete type
 struct sockaddr_vm vm;
^

--
components: Extension Modules
messages: 324427
nosy: mcduke
priority: normal
severity: normal
status: open
title: AF_VSOCK not unset because of wrong nesting
type: compile error
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com