[issue34573] Simplify __reduce__() of set and dict iterators.

2018-10-19 Thread STINNER Victor 


STINNER Victor  added the comment:

Thanks Sergey Fedoseev!

--
nosy: +vstinner
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-10-19 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:


New changeset 6395844e6adebc12c4eba1fb75c5e7c9c8b89f85 by Pablo Galindo (Sergey 
Fedoseev) in branch 'master':
bpo-34573: Simplify __reduce__() of set and dict iterators. (GH-9050)
https://github.com/python/cpython/commit/6395844e6adebc12c4eba1fb75c5e7c9c8b89f85


--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-07 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Perhaps the bug was specific to OrderedDict itrerators. I'll try to write 
additional tests, and after that I'll merge PR 9050.

--
assignee:  -> serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-04 Thread Kristján Valur Jónsson 

Kristján Valur Jónsson  added the comment:

Interesting, I'll have a look when I'm back from vacation.

On Tue, 4 Sep 2018, 07:04 Raymond Hettinger,  wrote:

>
> Raymond Hettinger  added the comment:
>
> Also take a look at the other places that have similar logic.  I believe
> these all went in at the same time. See commit
> 31668b8f7a3efc7b17511bb08525b28e8ff5f23a
>
> --
> nosy: +kristjan.jonsson, rhettinger
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-03 Thread Serhiy Storchaka 


Serhiy Storchaka  added the comment:

Seems there is a bug in the dict iter code, leading to a crash when pickle 
non-initial items iterator. Would be nice to add tests similar to issue34574, 
and if the bug will be exposed, fix it.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-03 Thread Raymond Hettinger 


Raymond Hettinger  added the comment:

Also take a look at the other places that have similar logic.  I believe these 
all went in at the same time. See commit 
31668b8f7a3efc7b17511bb08525b28e8ff5f23a

--
nosy: +kristjan.jonsson, rhettinger

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-03 Thread Sergey Fedoseev 


Change by Sergey Fedoseev :


--
keywords: +patch
pull_requests: +8512
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34573] Simplify __reduce__() of set and dict iterators.

2018-09-03 Thread Sergey Fedoseev 


New submission from Sergey Fedoseev :

Currently __reduce__() implementation of set and dict iterators saves items to 
list using next/PyList_Append(), it could be simplified by using 
PySequence_List().

--
components: Interpreter Core
messages: 324550
nosy: sir-sigurd
priority: normal
severity: normal
status: open
title: Simplify __reduce__() of set and dict iterators.
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com