[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 3e3e1a27f769b3385853fbcad6749e71ca7f3ce3 by Serhiy Storchaka in 
branch '2.7':
[2.7] bpo-35133: Fix mistakes when concatenate string literals on different 
lines. (GH-10284) (GH-10335) (GH-10336)
https://github.com/python/cpython/commit/3e3e1a27f769b3385853fbcad6749e71ca7f3ce3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +9641

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 7054e5c80b6e98cd44e22d1bc2d7f0a94343089d by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-35133: Fix mistakes when concatenate string literals on different 
lines. (GH-10284) (GH-10335)
https://github.com/python/cpython/commit/7054e5c80b6e98cd44e22d1bc2d7f0a94343089d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +9640

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[miss-islington]

miss-islington  added the comment:


New changeset 7beb8c54ede7669a59bb9b912ba0ffd8aa3998c6 by Miss Islington (bot) 
in branch '3.7':
bpo-35133: Fix mistakes when concatenate string literals on different lines. 
(GH-10284)
https://github.com/python/cpython/commit/7beb8c54ede7669a59bb9b912ba0ffd8aa3998c6


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[miss-islington]

Change by miss-islington :


--
pull_requests: +9639

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 34fd4c20198dea6ab2fe8dc6d32d744d9bde868d by Serhiy Storchaka in 
branch 'master':
bpo-35133: Fix mistakes when concatenate string literals on different lines. 
(GH-10284)
https://github.com/python/cpython/commit/34fd4c20198dea6ab2fe8dc6d32d744d9bde868d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Here is a script used for searching and fixing such errors. It produces a large 
number of false detections, so it need manual work for clearing the result. In 
general this can't be automated, because the correctness depends on the context.

--
Added file: https://bugs.python.org/file47906/fixstringssplit.py

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I am only unsure about email tests. Barry, David, could you please look? There 
may be errors in tests, but it may be that spaces are intentionally omitted, 
for testing cases without spaces. Tests are passed in any case, but I don't 
know the purpose of these tests.

--
nosy: +barry, r.david.murray

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +patch
pull_requests: +9595
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35133] Bugs in concatenating string literals on different lines

[Serhiy Storchaka]

New submission from Serhiy Storchaka :

The following PR fixes many bugs related to concatenating string literals on 
different lines. There are two kinds of errors:

1. Missed space. The first line is ended with a word, and the second line is 
started with a word. When they are concatenated, there is no space between 
words. This is the same issue as issue35128, but not only in warning messages, 
and not only in Python.

2. Missed comma in a list of string literals. This leads to concatenating the 
last string in the first line and the first list in the second line.

--
components: Library (Lib)
messages: 329059
nosy: serhiy.storchaka
priority: normal
severity: normal
status: open
title: Bugs in concatenating string literals on different lines
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com