[issue35147] _Py_NO_RETURN is always empty on GCC

[STINNER Victor]

STINNER Victor  added the comment:

Thanks Alexey Izbyshev!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[miss-islington]

miss-islington  added the comment:


New changeset a9122d183b1fbc4484d72aec69fc0979c7fd91f2 by Miss Islington (bot) 
(Alexey Izbyshev) in branch '3.7':
[3.7] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10301)
https://github.com/python/cpython/commit/a9122d183b1fbc4484d72aec69fc0979c7fd91f2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 29abad099535f4bcb1531df93bafbd75b26d6adc by Victor Stinner 
(Alexey Izbyshev) in branch '3.6':
[3.6] bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300) (GH-10302)
https://github.com/python/cpython/commit/29abad099535f4bcb1531df93bafbd75b26d6adc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
pull_requests: +9612

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
pull_requests: +9611

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[miss-islington]

miss-islington  added the comment:


New changeset e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd by Miss Islington (bot) 
(Alexey Izbyshev) in branch 'master':
bpo-35147: Fix _Py_NO_RETURN for GCC (GH-10300)
https://github.com/python/cpython/commit/e2ed5adcb5db2d70cfa72da1ba8446f7aa9e05cd


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[STINNER Victor]

STINNER Victor  added the comment:

Oh right, the major version is __GNUC__:
https://gcc.gnu.org/onlinedocs/cpp/Common-Predefined-Macros.html

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

Oh, this is common error!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[Alexey Izbyshev]

Change by Alexey Izbyshev :


--
keywords: +patch
pull_requests: +9609
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35147] _Py_NO_RETURN is always empty on GCC

[Alexey Izbyshev]

New submission from Alexey Izbyshev :

Non-existing __GNUC_MAJOR__ macro is used to check for GCC version at 
https://github.com/python/cpython/blob/b942707fc23454a998323c17e30be78ff1a4f0e7/Include/pyerrors.h#L97
 . __GNUC__ should be used instead.

--
components: Interpreter Core
messages: 329136
nosy: benjamin.peterson, berker.peksag, brett.cannon, izbyshev, serhiy.storchaka
priority: normal
severity: normal
status: open
title: _Py_NO_RETURN is always empty on GCC
type: behavior
versions: Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com