[issue35189] EINTR is not being retried

[Nierob]

Nierob  added the comment:

PR waits for CLA

--
keywords: +patch
nosy: +nierob
pull_requests: +9693
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35189] EINTR is not being retried

[STINNER Victor]

STINNER Victor  added the comment:

> https://github.com/nierob/cpython/commit/3b76b887b2b339664dc52c5f246bc7cb268ea616

Oh, nice! Please rebase this change on the master branch and reuse "int 
async_err = 0;" pattern from Modules/posixmodule.c. You must not raise a new 
exception if PyErr_CheckSignals() raised an exception, something like:

return (!async_err) ? posix_error() : NULL;

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35189] EINTR is not being retried

[Aapo Samuli Keskimolo]

Aapo Samuli Keskimolo  added the comment:

My colleague has made a prospective fix:

https://github.com/nierob/cpython/commit/3b76b887b2b339664dc52c5f246bc7cb268ea616

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35189] EINTR is not being retried

[STINNER Victor]

STINNER Victor  added the comment:

You're right, it should, but the fcntl module hasn't been patched. Are you 
interested to work or on patch, or do you want to me to find someone to do it?

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35189] EINTR is not being retried

[Aapo Samuli Keskimolo]

New submission from Aapo Samuli Keskimolo :

According to https://www.python.org/dev/peps/pep-0475/ the EINTR interruption 
should be retried automatically, but somehow it does not work and the exception 
is raised:

2018-11-05 05:21:35,257 ERROR:storage(23491): Remote storage operation failed 
(request: '{  'excludeSubModules': None,
   'storageLocation': 
'qt/qtdatavis3d/68faa5b00f73096eb096c6acdfce76b052ca20b9/LinuxUbuntu_18_04x86_64LinuxQEMUarm64GCCqtci-linux-Ubuntu-18.04-x86_64-a6
c9f7Release/ac4280d182ec320eaf0e68efaeeeb6be14b9689f/test_1542834179',
   'type': 3}')
Traceback (most recent call last):
  File "src/storage.py", line 507, in handle
self.handle_upload_artifact(message)
  File "src/storage.py", line 437, in handle_upload_artifact
log.info("upload of %s to %s", uploadType, message.storageLocation)
  File "/usr/lib/python3.6/logging/__init__.py", line 1306, in info
self._log(INFO, msg, args, **kwargs)
  File "/usr/lib/python3.6/logging/__init__.py", line 1442, in _log
self.handle(record)
  File "/usr/lib/python3.6/logging/__init__.py", line 1452, in handle
self.callHandlers(record)
  File "/usr/lib/python3.6/logging/__init__.py", line 1514, in callHandlers
hdlr.handle(record)
  File "/usr/lib/python3.6/logging/__init__.py", line 861, in handle
self.acquire()
  File "/home/vmbuilder/qt-ci/src/application.py", line 151, in acquire
fcntl.lockf(self._lock_fd, fcntl.LOCK_EX)
InterruptedError: [Errno 4] Interrupted system call

--
components: Library (Lib)
messages: 329469
nosy: akeskimo
priority: normal
severity: normal
status: open
title: EINTR is not being retried
type: crash
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com