[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Nick Coghlan]

Nick Coghlan  added the comment:

Fixed for Python 3.8 via the patch for #35936. We won't be backporting that 
patch as it also migrates modulefinder from the deprecated imp API to the 
supported importlib one, and is hence considered overly intrusive for a bug fix 
release.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 2.7, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Brandt Bucher]

Change by Brandt Bucher :


--
pull_requests: +11785

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Brett Cannon]

Brett Cannon  added the comment:

PRs should always be against 'master' unless the issue is already fixed there.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Brett Cannon]

Change by Brett Cannon :


--
nosy: +jvr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Brett Cannon]

Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[Brett Cannon]

Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[rdb]

Change by rdb :


--
pull_requests:  -10133

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[rdb]

Change by rdb :


--
pull_requests: +10134

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[rdb]

Change by rdb :


--
pull_requests: +10133

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[SilentGhost]

Change by SilentGhost :


--
nosy: +brett.cannon, eric.snow, ncoghlan
stage:  -> patch review
versions:  -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35376] modulefinder skips nested modules with same name as top-level bad module

[rdb]

New submission from rdb :

If modulefinder finds a nested module import (eg. 'import a.b.c') while there 
is a top-level module with the same name (eg. 'c') that failed to import and 
got added to the badmodules list, it will skip it entirely without even trying 
to import it.

This has a trivial fix (attached).  The right thing to do is clearly to check 
it by fqname in the badmodules dict since that's also what it expects in other 
locations.

I can make a PR as soon as my CLA gets validated, if that is more convenient.  
(Which branch should I make the PR against?)

--
components: Library (Lib)
files: patch.diff
keywords: patch
messages: 330883
nosy: rdb
priority: normal
severity: normal
status: open
title: modulefinder skips nested modules with same name as top-level bad module
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8
Added file: https://bugs.python.org/file47968/patch.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com