[issue35936] Give modulefinder some much-needed updates.

[Nick Coghlan]

Nick Coghlan  added the comment:


New changeset 9d7b2c0909b78800d1376fd696f73824ea680463 by Nick Coghlan (Brandt 
Bucher) in branch 'master':
bpo-35936: Updates to modulefinder (GH-11787)
https://github.com/python/cpython/commit/9d7b2c0909b78800d1376fd696f73824ea680463


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Nick Coghlan]

Nick Coghlan  added the comment:

Thanks Brandt!

I'll also go back and close #17396, #35376, and #25160

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

Change by Brandt Bucher :


--
nosy: +barry, brett.cannon, ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

Brandt Bucher  added the comment:

Alright, I've gotten all of the tests passing for the new importlib-only 
implementation. I broke these modifications out into a new private function, 
_find_module, to make it clear that this fix is a simple drop-in replacement 
for imp.find_module.

Let me know if there's anything I've missed or could improve. Otherwise, I feel 
my work here is done!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[SilentGhost]

Change by SilentGhost :


--
nosy: +jvr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

Change by Brandt Bucher :


--
keywords: +patch
pull_requests: +11779
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

Change by Brandt Bucher :


--
keywords: +patch, patch
pull_requests: +11779, 11780
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

New submission from Brandt Bucher :

I've written a patch here that includes a few useful fixes. Namely:

- It doesn't crash if it encounters a syntax error. (17396)
- It doesn't report certain name collisions as bad. (35376)
- It doesn't use mutable default arguments in its initializer.
- Most importantly, it now uses `importlib` instead of `imp`, which is 
deprecated. (25160) As a benefit, frozen built-in modules (`zip import`, for 
example), are now correctly reported.

With the exception of these bug fixes, I've been very careful to preserve the 
original behavior, and have not changed any part of the API. This patch also 
includes 2 new regression tests.

--
versions: +Python 3.8 -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35936] Give modulefinder some much-needed updates.

[Brandt Bucher]

Change by Brandt Bucher :


--
components: Library (Lib)
nosy: brandtbucher
priority: normal
severity: normal
status: open
title: Give modulefinder some much-needed updates.
type: enhancement
versions: Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com