[issue36025] Breaking change in PyDate_FromTimeStamp API

[Berker Peksag]

Change by Berker Peksag :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36025] Breaking change in PyDate_FromTimeStamp API

[Berker Peksag]

Berker Peksag  added the comment:


New changeset 4d8c8c0ad6163c24136d3419eb04f310b31f7e64 by Berker Peksag (Paul 
Ganssle) in branch 'master':
bpo-36025: Fix PyDate_FromTimestamp API (GH-11922)
https://github.com/python/cpython/commit/4d8c8c0ad6163c24136d3419eb04f310b31f7e64


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36025] Breaking change in PyDate_FromTimeStamp API

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

I prefer option 2. Your PR LGTM.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36025] Breaking change in PyDate_FromTimeStamp API

[Paul Ganssle]

Paul Ganssle  added the comment:

I've put *a* fix in there by introducing a new wrapper function. Ideally we 
would just point the C API at the argument clinic-generated function, but 
because it takes a single positional argument the argument clinic outputs a 
METH_O function instead of METH_VARARGS.

I think these are the options:

1. Modify the argument clinic spec to force METH_VARARGS for a single 
positional argument taking an object - if that's possible.
2. Maintain a wrapper function for the C API that just unpacks the tuple and 
passes it to the date_fromtimestamp function that the argument clinic is *also* 
wrapping.
3. Revert the argument clinic change and manually manage the date_fromtimestamp 
function as a METH_VARARGS classmethod.

I don't know enough about the argument clinic to know if #1 is feasible, if it 
is and someone can point me in the right direction, I can update my PR. If not, 
I think I mildly prefer #2, since maintaining a thin wrapper that unpacks a 
tuple is not terribly difficult compared to maintaining the method definition 
stuff.

Since this was an accidental break in the C API, I've marked it as a release 
blocker.

--
nosy: +lukasz.langa
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36025] Breaking change in PyDate_FromTimeStamp API

[Paul Ganssle]

Change by Paul Ganssle :


--
keywords: +patch
pull_requests: +11947
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36025] Breaking change in PyDate_FromTimeStamp API

[Paul Ganssle]

New submission from Paul Ganssle :

The PyO3 test suite has been breaking since the alpha release of Python 3.8 
because PyDateTimeAPI->Date_FromTimeStamp has had a breaking change in its API: 
https://github.com/PyO3/pyo3/issues/352

I believe this happened when `datetime.date.fromtimestamp` and 
`datetime.datetime.fromtimestamp` were converted over to using the argument 
clinic. The function `date_from_local_object` was renamed to 
`date_fromtimestamp`, without a corresponding change to the PyDateTimeCAPI 
struct.

--
assignee: p-ganssle
components: Library (Lib)
messages: 335854
nosy: belopolsky, p-ganssle, petr.viktorin, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Breaking change in PyDate_FromTimeStamp API
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com