[issue36027] Support negative exponents in pow() where a modulus is specified.

[miss-islington]

Change by miss-islington :


--
nosy: +miss-islington
nosy_count: 10.0 -> 11.0
pull_requests: +25288
pull_request: https://github.com/python/cpython/pull/26702

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Change by Mark Dickinson :


--
pull_requests: +25287
pull_request: https://github.com/python/cpython/pull/26703

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Change by Mark Dickinson :


--
pull_requests: +25277
pull_request: https://github.com/python/cpython/pull/26690

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[paul rubin]

paul rubin  added the comment:

https://bugs.python.org/issue457066  The old is new again ;-).

--
nosy: +phr

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Mark Dickinson  added the comment:

For tracker historians: see also #457066

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Mark Dickinson  added the comment:

@Petr: Thanks for the quick fix!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Petr Viktorin]

Petr Viktorin  added the comment:


New changeset 1e375c6269e9de4f3d05d4aa6d6d74e00f522d63 by Petr Viktorin in 
branch 'master':
bpo-36027: Really fix "incompatible pointer type" compiler warning (GH-13761)
https://github.com/python/cpython/commit/1e375c6269e9de4f3d05d4aa6d6d74e00f522d63


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Petr Viktorin]

Change by Petr Viktorin :


--
pull_requests: +13646
pull_request: https://github.com/python/cpython/pull/13761

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Petr Viktorin]

Petr Viktorin  added the comment:


New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in 
branch 'master':
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings 
(GH-13758)
https://github.com/python/cpython/commit/e584cbff1ea78e700cf9943d50467e3b58301ccc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Petr Viktorin]

Change by Petr Viktorin :


--
pull_requests: +13639
pull_request: https://github.com/python/cpython/pull/13758

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Petr Viktorin]

Petr Viktorin  added the comment:

I will fix the compiler warning along with another one that I just introduced.

--
nosy: +petr.viktorin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

PR 13266 introduced a compiler warning.

Objects/longobject.c: In function ‘long_invmod’:
Objects/longobject.c:4246:25: warning: passing argument 2 of ‘long_compare’ 
from incompatible pointer type [-Wincompatible-pointer-types]
 if (long_compare(a, _PyLong_One)) {
 ^~~
Objects/longobject.c:3057:1: note: expected ‘PyLongObject * {aka struct 
_longobject *}’ but argument is of type ‘PyObject * {aka struct _object *}’
 long_compare(PyLongObject *a, PyLongObject *b)
 ^~~~

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Mark Dickinson  added the comment:

Done. Closing.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Mark Dickinson  added the comment:


New changeset c52996785a45d4693857ea219e040777a14584f8 by Mark Dickinson in 
branch 'master':
bpo-36027: Extend three-argument pow to negative second argument (GH-13266)
https://github.com/python/cpython/commit/c52996785a45d4693857ea219e040777a14584f8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Mark Dickinson  added the comment:

I think GH-13266 is ready to go, but I'd appreciate a second pair of eyes on it 
if anyone has time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Change by Mark Dickinson :


--
assignee:  -> mark.dickinson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Mark Dickinson]

Change by Mark Dickinson :


--
keywords: +patch
pull_requests: +13174
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Berry Schoenmakers]

Berry Schoenmakers  added the comment:

In pure Python this seems to be the better option to compute inverses:

def modinv(a, m):  # assuming m > 0
b = m
s, s1 = 1, 0
while b:
a, (q, b) = b, divmod(a, b)
s, s1 = s1, s - q * s1
if a != 1:
raise ValueError('inverse does not exist')
return s if s >= 0 else s + m

Binary xgcd algorithms coded in pure Python run much slower.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36027] Support negative exponents in pow() where a modulus is specified.

[Raymond Hettinger]

Raymond Hettinger  added the comment:

Changing the title to reflect a focus on building-out pow() instead of a 
function in the math module.

--
title: Consider adding modular multiplicative inverse to the math module -> 
Support negative exponents in pow() where a modulus is specified.

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com