[issue36740] zipimporter misses namespace packages for implicit dirs

[Barry A. Warsaw]

Change by Barry A. Warsaw :


--
nosy: +barry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36740] zipimporter misses namespace packages for implicit dirs

[Jason R. Coombs]

Change by Jason R. Coombs :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> zipimport needs to support namespace packages when no 
'directory' entry exists

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36740] zipimporter misses namespace packages for implicit dirs

[Eric V. Smith]

Eric V. Smith  added the comment:

This is a duplicate of issue 14905.

--
nosy: +eric.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36740] zipimporter misses namespace packages for implicit dirs

[Jason R. Coombs]

New submission from Jason R. Coombs :

As discovered in https://github.com/pypa/packaging-problems/issues/212, if a 
PEP 420 namespace package is represented by an implicit directory (that is, 
there's no explicit entry for the directory, only entries for the contents of 
the directory), that directory won't be picked up as a namespace package. The 
following code illustrates the issue:

```
zp $ cat make-pkgs.py   

   
import zipfile


def make_pkgs():
zf = zipfile.ZipFile('simple.zip', 'w')
zf.writestr('pkg/__init__.py', b'')
zf.close()

zf = zipfile.ZipFile('namespace.zip', 'w')
zf.writestr('ns/pkg/__init__.py', b'')
zf.close()


__name__ == '__main__' and make_pkgs()
zp $ python make-pkgs.py

   
zp $ env PYTHONPATH=simple.zip python3.7 -c "import pkg"

   
zp $ env PYTHONPATH=namespace.zip python3.7 -c "import ns.pkg"  

   
Traceback (most recent call last):
  File "", line 1, in 
ModuleNotFoundError: No module named 'ns'
```

As you can see, in simple.zip, the `pkg` directory is implied, but despite that 
condition, `pkg` is importable.

However, with namespace.zip, the name `ns` is not visible even though it's 
present in the zipfile and would be importable if that zipfile were extracted 
to a file system.

```
zp $ unzip namespace.zip
Archive:  namespace.zip
 extracting: ns/pkg/__init__.py
zp $ python3.7 -c "import ns.pkg" && echo done
done
```

If you were to reconstruct that zip file on the file system using standard 
tools or explicitly include 'ns/' in the zip entries, the namespace package 
becomes visible:

```
zp $ rm namespace.zip   

   
zp $ zip -r namespace.zip ns

   
  adding: ns/ (stored 0%)
  adding: ns/pkg/ (stored 0%)
  adding: ns/pkg/__init__.py (stored 0%)
  adding: ns/pkg/__pycache__/ (stored 0%)
  adding: ns/pkg/__pycache__/__init__.cpython-37.pyc (deflated 23%)
zp $ rm -r ns   

   
zp $ env PYTHONPATH=namespace.zip python3.7 -c "import ns.pkg" && echo done 

   
done
```

For consistency, the zip import logic should probably honor implicit 
directories in zip files.

--
components: Library (Lib)
messages: 340975
nosy: jaraco
priority: normal
severity: normal
status: open
title: zipimporter misses namespace packages for implicit dirs
type: behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com