[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Andrew Svetlov  added the comment:


New changeset 54b74fe9df89f0e5646736f1f60376b4e37c422c by Andrew Svetlov in 
branch 'master':
bpo-36801: Temporarily fix regression in writer.drain() (#13330)
https://github.com/python/cpython/commit/54b74fe9df89f0e5646736f1f60376b4e37c422c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Change by Andrew Svetlov :


--
pull_requests: +13242

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13241
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[STINNER Victor]

STINNER Victor  added the comment:


New changeset c647ad9b51c59f71c02cd90c5e67d1b2768323ca by Victor Stinner in 
branch '3.7':
Revert "bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport 
(GH-13098)" (GH-13328)
https://github.com/python/cpython/commit/c647ad9b51c59f71c02cd90c5e67d1b2768323ca


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Looks like the change introduced by the PR is not stable at least on Windows 
boxes

--
resolution: fixed -> 
stage: resolved -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +13240

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[miss-islington]

miss-islington  added the comment:


New changeset 93aa57ac6594d1cc30d147720fc8a7a4e1ca2d3e by Miss Islington (bot) 
in branch '3.7':
bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport 
(GH-13098)
https://github.com/python/cpython/commit/93aa57ac6594d1cc30d147720fc8a7a4e1ca2d3e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[miss-islington]

Change by miss-islington :


--
pull_requests: +13092

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[miss-islington]

miss-islington  added the comment:


New changeset 1cc0ee7d9f6a2817918fafd24c18d8bb093a85d3 by Miss Islington (bot) 
(Andrew Svetlov) in branch 'master':
bpo-36801: Fix waiting in StreamWriter.drain for closing SSL transport 
(GH-13098)
https://github.com/python/cpython/commit/1cc0ee7d9f6a2817918fafd24c18d8bb093a85d3


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Change by Andrew Svetlov :


--
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

Change by Andrew Svetlov :


--
keywords: +patch
pull_requests: +13011
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36801] Wait for connection_lost in StreamWriter.drain

[Andrew Svetlov]

New submission from Andrew Svetlov :

Now `await writer.drain()` performs `await sleep(0)` if underlying transport is 
closing.

It works well only for plain sockets. SSL transport needs more context switches 
to shut down the SSL connection.
Drain wakes up too early to check if the transport is actually closed.

--
components: asyncio
messages: 341445
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Wait for connection_lost in StreamWriter.drain
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com