[issue36991] zipfile: AttributeError on extract

[Gregory P. Smith]

Change by Gregory P. Smith :


--
stage: patch review -> resolved
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Irit Katriel]

Irit Katriel  added the comment:

This seems resolved, can we close?

--
nosy: +iritkatriel
resolution:  -> fixed
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[miss-islington]

miss-islington  added the comment:


New changeset 717cc61ed103684b8c73e0e8af10ace345f39f16 by Miss Islington (bot) 
in branch '3.8':
bpo-36991: Fix incorrect exception escaping ZipFile.extract() (GH-13632)
https://github.com/python/cpython/commit/717cc61ed103684b8c73e0e8af10ace345f39f16


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[miss-islington]

Change by miss-islington :


--
keywords: +patch
pull_requests: +15674
pull_request: https://github.com/python/cpython/pull/16052

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Gregory P. Smith]

Gregory P. Smith  added the comment:


New changeset 2f1b857562b0f1601c9019db74c29b7d7e21ac9f by Gregory P. Smith 
(Berker Peksag) in branch 'master':
bpo-36991: Fix incorrect exception escaping ZipFile.extract() (GH-13632)
https://github.com/python/cpython/commit/2f1b857562b0f1601c9019db74c29b7d7e21ac9f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Gregory P. Smith]

Change by Gregory P. Smith :


--
assignee:  -> gregory.p.smith
nosy: +gregory.p.smith
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Berker Peksag]

Berker Peksag  added the comment:

The OP's report is valid and they already stated that the file is malformed. 
More importantly, this can be reproduced with a valid ZIP file as well.

The correct behavior is to get RuntimeError in this case.

_check_compression() needs to be called before _get_decompressor().

There is no issue when getting the compressor object because 
_check_compression() is called inside _writecheck().

--
components: +Library (Lib)
nosy: +berker.peksag, serhiy.storchaka
resolution: not a bug -> 
stage: resolved -> patch review
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Berker Peksag]

Change by Berker Peksag :


--
pull_requests: +13532
pull_request: https://github.com/python/cpython/pull/13632

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

I also recommend that you read this document about the compilation and 
installation of Python and its dependencies.

https://devguide.python.org/setup/#compile-and-build

Thank you

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[Stéphane Wirtel]

Stéphane Wirtel  added the comment:

Hi, 

Thank you for your report

1. but do you have the bz2 lib on your system, because without that, Python is 
not compiled with the support of this format.

2. your file seems to have an issue.

 unzip attr0.zip 
Archive:  attr0.zip
  inflating: zipfile_extract.py  
  error:  invalid compressed data to inflate
 bad CRC   (should be 88075377)

Please could you check again your compilation step and retry with an other file.

I'm closing this issue.

Thank you

--
nosy: +matrixise
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue36991] zipfile: AttributeError on extract

[alter-bug-tracer]

New submission from alter-bug-tracer :

The following code throws an AttributeError when attempting to extract a 
malformed archive (attached):

import zipfile
import sys

zf = zipfile.ZipFile(sys.argv[1])
for info in zf.infolist():
  zf.extract(info.filename)

Result:
Traceback (most recent call last):
  File "code.py", line 6, in 
zf.extract(info.filename)
  File "/usr/local/lib/python3.8/zipfile.py", line 1607, in extract
return self._extract_member(member, path, pwd)
  File "/usr/local/lib/python3.8/zipfile.py", line 1677, in _extract_member
with self.open(member, pwd=pwd) as source, \
  File "/usr/local/lib/python3.8/zipfile.py", line 1548, in open
return ZipExtFile(zef_file, mode, zinfo, zd, True)
  File "/usr/local/lib/python3.8/zipfile.py", line 801, in __init__
self._decompressor = _get_decompressor(self._compress_type)
  File "/usr/local/lib/python3.8/zipfile.py", line 708, in _get_decompressor
return bz2.BZ2Decompressor()
AttributeError: 'NoneType' object has no attribute 'BZ2Decompressor'

--
files: attr0.zip
messages: 343035
nosy: alter-bug-tracer
priority: normal
severity: normal
status: open
title: zipfile: AttributeError on extract
type: behavior
versions: Python 3.8
Added file: https://bugs.python.org/file48346/attr0.zip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com