[issue3713] Compile warning for Objects/stringlib

2008-08-28 Thread Andy

New submission from Andy [EMAIL PROTECTED]:

Checked out the PY3K branch and built. Received a warning 
about characters after #ifdef ignored from Objects/stringlib/find.h

the line in question is:

#ifdef STRINGLIB_WANT_CONTAINS_OBJ  !defined(FROM_BYTEARRAY)

Which is likely to mean that it will not do what is expected.

System is Ubuntu using GCC (otoh can't remember full compiler spec will 
post in later)

Patch to follow that modifies the above line to:

#if defined(STRINGLIB_WANT_CONTAINS_OBJ)  !defined(FROM_BYTEARRAY)

and will change the comment on the closing #endif too.

hope component choice is correct

--
components: Library (Lib)
messages: 72087
nosy: kirkshorts
severity: normal
status: open
title: Compile warning for Objects/stringlib
versions: Python 3.0

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3713] Compile warning for Objects/stringlib

2008-08-28 Thread Andy

Andy [EMAIL PROTECTED] added the comment:

patch for issue attached.

gcc -v = gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)

tests:

./runtests.sh =
   0 BAD
 297 GOOD
  27 SKIPPED
 324 total

--
keywords: +patch
Added file: http://bugs.python.org/file11291/issue3713.patch

___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3713
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com