[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Welcome!
Thanks for the fix!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

STINNER Victor  added the comment:

Thanks for the review Andrew.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

Change by STINNER Victor :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[miss-islington]

miss-islington  added the comment:


New changeset 8b66dbb212d7dffbf9fb545dad2a3400aead1461 by Miss Islington (bot) 
in branch '3.8':
bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
https://github.com/python/cpython/commit/8b66dbb212d7dffbf9fb545dad2a3400aead1461


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[miss-islington]

Change by miss-islington :


--
pull_requests: +13936
pull_request: https://github.com/python/cpython/pull/14078

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[miss-islington]

Change by miss-islington :


--
pull_requests: +13935
pull_request: https://github.com/python/cpython/pull/14077

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 07559450b2d9179e4c99e0af088ce7550e549f94 by Victor Stinner in 
branch 'master':
bpo-37278: Fix test_asyncio ProactorLoopCtrlC (GH-14074)
https://github.com/python/cpython/commit/07559450b2d9179e4c99e0af088ce7550e549f94


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Maybe. Agree with your decision to close bpo-34520 as duplicate.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

STINNER Victor  added the comment:

bpo-34520 *might* be an old duplicate of this bug.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +13932
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14074

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37278] test_asyncio: ProactorLoopCtrlC leaks one reference

[STINNER Victor]

New submission from STINNER Victor :

vstinner@WIN C:\vstinner\python\master>python -m test -R 3:3 test_asyncio -m 
test.test_asyncio.test_windows_events.ProactorLoopCtrlC.test_ctrl_c
Running Debug|x64 interpreter...
Run tests sequentially
0:00:00 load avg: 0.00 [1/1] test_asyncio
beginning 6 repetitions
123456
..
test_asyncio leaked [1, 1, 1] references, sum=3
test_asyncio leaked [2, 1, 1] memory blocks, sum=4
test_asyncio failed

== Tests result: FAILURE ==

1 test failed:
test_asyncio

Total duration: 13 sec 391 ms
Tests result: FAILURE



Attached PR fix the issue by joining the thread.

--
components: Tests, asyncio
messages: 345570
nosy: asvetlov, vstinner, yselivanov
priority: normal
severity: normal
status: open
title: test_asyncio: ProactorLoopCtrlC leaks one reference
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com