[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:

ResourceWarning is no longer emitted. I close the issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Christian Heimes  added the comment:

I have cherry-picked e047239eafefe8b19725efffe7756443495cf78b into both 
backports and rebased them on top of upstream/3.8 and upstream/3.9.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Łukasz Langa]

Łukasz Langa  added the comment:

I re-ran CI on the pull requests, the 3.8 and 3.9 failures on Windows X64 and 
macOS reproduced the same.

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +24292
pull_request: https://github.com/python/cpython/pull/25573

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +24291
pull_request: https://github.com/python/cpython/pull/25572

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Christian Heimes  added the comment:


New changeset c8666cfa7cdc48915a14cd16095a69029720736a by Christian Heimes in 
branch 'master':
bpo-37322: Fix ResourceWarning and exception handling in test (GH-25553)
https://github.com/python/cpython/commit/c8666cfa7cdc48915a14cd16095a69029720736a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Change by Christian Heimes :


--
pull_requests: +24273
pull_request: https://github.com/python/cpython/pull/25553

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Christian Heimes]

Christian Heimes  added the comment:

I wasn't aware of this bpo and created bpo-43885 a couple of days ago. 

tl;dr I do not understand test changes in 
fb7e7505ed1337bf40fa7b8b68317d1e86675a86 at all. I think that these changes are 
broken, too. ThreadedEchoServer and ConnectionHandler must not raise unhandled 
exceptions. An unhandled exception can break tests and sometimes causes 
threaded tests to hang indefinitely.

--
nosy: +christian.heimes
priority: normal -> high
versions: +Python 3.10, Python 3.11, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Matthew Hughes]

Change by Matthew Hughes :


--
pull_requests: +20541
pull_request: https://github.com/python/cpython/pull/21393

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Matthew Hughes]

Matthew Hughes  added the comment:

Whoops, I realise the patch I shared contained a combination of two 
(independent) approaches I tried:

1. Add sleep and perform cleanup
2. Naively patch catch_threading_exception to accept a cleanup routine to be 
run upon exiting but before removing the thread.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[Matthew Hughes]

Matthew Hughes  added the comment:

I noticed this test was still emitting a "ResourceWarning":
--
$ ./python -m test test_ssl -m TestPostHandshakeAuth 
0:00:00 load avg: 0.74 Run tests sequentially
0:00:00 load avg: 0.74 [1/1] test_ssl
/home/mjh/src/cpython/Lib/test/support/threading_helper.py:209: 
ResourceWarning: unclosed 
  del self.thread
ResourceWarning: Enable tracemalloc to get the object allocation traceback

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.1 sec
Tests result: SUCCESS
--
and thought I would try silencing it by ensuring the SSL connection handled by 
the separate thread was closed before exiting. My attempt involved checking the 
thread's exception and acting accordingly, but I ran into a race condition 
which (solely as a proof of concept) I resolved by adding a sleep() call (see 
patch).

While I continue to search for a proper resolution I was wondering what 
approach someone with more insight might suggest.

--
nosy: +mhughes
Added file: https://bugs.python.org/file49294/naive_proof_of_concept.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[miss-islington]

miss-islington  added the comment:


New changeset 4c403b8ca2d0ef44b691cceaeeac9e110fd3f05a by Miss Islington (bot) 
in branch '3.8':
bpo-37322: ssl test_pha_required_nocert() ignores expected SSLError (GH-14670)
https://github.com/python/cpython/commit/4c403b8ca2d0ef44b691cceaeeac9e110fd3f05a


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 73ea54620a6f91c3f2e53880373dd47813691a21 by Victor Stinner in 
branch 'master':
bpo-37322: ssl test_pha_required_nocert() ignores expected SSLError (GH-14670)
https://github.com/python/cpython/commit/73ea54620a6f91c3f2e53880373dd47813691a21


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[miss-islington]

Change by miss-islington :


--
pull_requests: +14481
pull_request: https://github.com/python/cpython/pull/14673

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:

The test also logs an "Exception in thread Thread-2:" error:
---
vstinner@apu$ ./python -m test test_ssl -m test_pha_required_nocert -v
== CPython 3.9.0a0 (heads/master:110a47c4f4, Jul 8 2019, 23:52:00) [GCC 9.1.1 
20190503 (Red Hat 9.1.1-1)]
== Linux-5.1.15-300.fc30.x86_64-x86_64-with-glibc2.29 little-endian
== cwd: /home/vstinner/python/master/build/test_python_21491
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
Run tests sequentially
0:00:00 load avg: 1.77 [1/1] test_ssl
test_ssl: testing with 'OpenSSL 1.1.1c FIPS  28 May 2019' (1, 1, 1, 3, 15)
  under 'Linux-5.1.15-300.fc30.x86_64-x86_64-with-glibc2.29'
  HAS_SNI = True
  OP_ALL = 0x8054
  OP_NO_TLSv1_1 = 0x1000
test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth) ... Exception in 
thread Thread-2:
Traceback (most recent call last):
  File "/home/vstinner/python/master/Lib/test/test_ssl.py", line 2299, in run
msg = self.read()
  File "/home/vstinner/python/master/Lib/test/test_ssl.py", line 2276, in read
return self.sslconn.read()
  File "/home/vstinner/python/master/Lib/ssl.py", line 1101, in read
return self._sslobj.read(len)
ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a 
certificate (_ssl.c:2560)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vstinner/python/master/Lib/threading.py", line 938, in 
_bootstrap_inner
self.run()
  File "/home/vstinner/python/master/Lib/test/test_ssl.py", line 2385, in run
raise ssl.SSLError('tlsv13 alert certificate required')
ssl.SSLError: ('tlsv13 alert certificate required',)
/home/vstinner/python/master/Lib/threading.py:938: ResourceWarning: unclosed 

  self.run()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
ok

--

Ran 1 test in 0.028s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 179 ms
Tests result: SUCCESS
---

Attached PR 14670 makes this log quiet.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14478
pull_request: https://github.com/python/cpython/pull/14670

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 61b1bc56069719fc6f17c73fdf2193636dbf6cc2 by Victor Stinner in 
branch 'master':
Revert "bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning 
(GH-14662)" (GH-14669)
https://github.com/python/cpython/commit/61b1bc56069719fc6f17c73fdf2193636dbf6cc2


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:

> New changeset cf9c41c422de3774862db964fe3153086bad3f61 by Victor Stinner in 
> branch 'master':
> bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662)

Oh. This test started to fail on Windows with this change. Example:

https://buildbot.python.org/all/#/builders/3/builds/3121

ERROR: test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth)
--
Traceback (most recent call last):
  File "D:\buildarea\3.x.bolen-windows10\build\lib\test\test_ssl.py", line 
4344, in test_pha_required_nocert
s.recv(1024)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\ssl.py", line 1226, in recv
return self.read(buflen)
  File "D:\buildarea\3.x.bolen-windows10\build\lib\ssl.py", line 1101, in read
return self._sslobj.read(len)
ConnectionResetError: [WinError 10054] An existing connection was forcibly 
closed by the remote host

I proposed PR 14669 to revert it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14477
pull_request: https://github.com/python/cpython/pull/14669

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14475
pull_request: https://github.com/python/cpython/pull/14667

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[miss-islington]

Change by miss-islington :


--
pull_requests: +14473
pull_request: https://github.com/python/cpython/pull/14665

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:


New changeset cf9c41c422de3774862db964fe3153086bad3f61 by Victor Stinner in 
branch 'master':
bpo-37322: Fix test_ssl.test_pha_required_nocert() ResourceWarning (GH-14662)
https://github.com/python/cpython/commit/cf9c41c422de3774862db964fe3153086bad3f61


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

Change by STINNER Victor :


--
keywords: +patch
pull_requests: +14470
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/14662

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

STINNER Victor  added the comment:

I marked bpo-37525 as duplicate of this issue.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37322] test_ssl: test_pha_required_nocert() emits a ResourceWarning

[STINNER Victor]

New submission from STINNER Victor :

vstinner@apu$ ./python -X tracemalloc=10 -m test --fail-env-changed -v test_ssl 
-m test_pha_required_nocert
== CPython 3.9.0a0 (heads/master-dirty:00f6493084, Jun 17 2019, 21:50:32) [GCC 
9.1.1 20190503 (Red Hat 9.1.1-1)]
== Linux-5.1.6-300.fc30.x86_64-x86_64-with-glibc2.29 little-endian
== cwd: /home/vstinner/prog/python/master/build/test_python_23407
== CPU count: 8
== encodings: locale=UTF-8, FS=utf-8
Run tests sequentially
0:00:00 load avg: 0.58 [1/1] test_ssl
test_ssl: testing with 'OpenSSL 1.1.1c FIPS  28 May 2019' (1, 1, 1, 3, 15)
  under 'Linux-5.1.6-300.fc30.x86_64-x86_64-with-glibc2.29'
  HAS_SNI = True
  OP_ALL = 0x8054
  OP_NO_TLSv1_1 = 0x1000
test_pha_required_nocert (test.test_ssl.TestPostHandshakeAuth) ... Exception in 
thread Thread-2:
Traceback (most recent call last):
  File "/home/vstinner/prog/python/master/Lib/test/test_ssl.py", line 2287, in 
run
msg = self.read()
  File "/home/vstinner/prog/python/master/Lib/test/test_ssl.py", line 2264, in 
read
return self.sslconn.read()
  File "/home/vstinner/prog/python/master/Lib/ssl.py", line 1090, in read
return self._sslobj.read(len)
ssl.SSLError: [SSL: PEER_DID_NOT_RETURN_A_CERTIFICATE] peer did not return a 
certificate (_ssl.c:2540)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vstinner/prog/python/master/Lib/threading.py", line 938, in 
_bootstrap_inner
self.run()
  File "/home/vstinner/prog/python/master/Lib/test/test_ssl.py", line 2373, in 
run
raise ssl.SSLError('tlsv13 alert certificate required')
ssl.SSLError: ('tlsv13 alert certificate required',)
/home/vstinner/prog/python/master/Lib/threading.py:938: ResourceWarning: 
unclosed 
  self.run()
Object allocated at (most recent call last):
  File "/home/vstinner/prog/python/master/Lib/threading.py", lineno 896
self._bootstrap_inner()
  File "/home/vstinner/prog/python/master/Lib/threading.py", lineno 938
self.run().
  File "/home/vstinner/prog/python/master/Lib/test/test_ssl.py", lineno 2283
if not self.wrap_conn():
  File "/home/vstinner/prog/python/master/Lib/test/test_ssl.py", lineno 2207
self.sslconn = self.server.context.wrap_socket(
  File "/home/vstinner/prog/python/master/Lib/ssl.py", lineno 489
return self.sslsocket_class._create(
  File "/home/vstinner/prog/python/master/Lib/ssl.py", lineno 992
self = cls.__new__(cls, **kwargs)
ok

--

Ran 1 test in 0.100s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 sec 430 ms
Tests result: SUCCESS


The test fails using -Werror.

--
components: Tests
messages: 345903
nosy: vstinner
priority: normal
severity: normal
status: open
title: test_ssl: test_pha_required_nocert() emits a ResourceWarning
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com