[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Change by Stefan Behnel :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Stefan Behnel  added the comment:


New changeset bb697899aa65d90488af1950ac7cceeb3877d409 by Stefan Behnel in 
branch '3.8':
[3.8] bpo-37399: Correctly attach tail text to the last element/comment/pi 
(GH-14856) (GH-14936)
https://github.com/python/cpython/commit/bb697899aa65d90488af1950ac7cceeb3877d409


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Change by Stefan Behnel :


--
pull_requests: +14709
pull_request: https://github.com/python/cpython/pull/14936

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Stefan Behnel  added the comment:


New changeset c6cb4cdd21c0c3a09b0617dbfaa7053d3bfa6def by Stefan Behnel in 
branch 'master':
bpo-37399: Correctly attach tail text to the last element/comment/pi (GH-14856)
https://github.com/python/cpython/commit/c6cb4cdd21c0c3a09b0617dbfaa7053d3bfa6def


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Change by Stefan Behnel :


--
keywords: +patch
pull_requests: +14646
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/14856

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Stefan Behnel  added the comment:

I'm working on a patch. It's not entirely trivial, so it might take a couple of 
days.

--
assignee:  -> scoder

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Jeffrey Kintscher]

Change by Jeffrey Kintscher :


--
nosy: +Jeffrey.Kintscher

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Dima Tisnek]

Dima Tisnek  added the comment:

Yes that does look suspicious!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Stefan Behnel]

Stefan Behnel  added the comment:

I think it might be this call that strikes here:

https://github.com/python/cpython/commit/43851a202c#diff-f3b827d6e1d5c270ab42bc2c0523c1d2R2842

treebuilder_flush_data() is not made for concatenating text, it simply replaces 
it. If both text parts come separately, and the comment between the two is 
discarded, then the last one overwrites the first one.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Just to add the Python implementation seems to return "foobar" on commenting 
the C accelerators imports. So I guess it's a problem with the C implementation 
in the commit being different from Python implementation.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
components: +XML

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
keywords: +3.8regression
stage:  -> needs patch
type:  -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

Bisecting gives me commit 43851a202c (issue36673) before which "foobar" was 
returned and after the commit "bar" is returned.

--
nosy: +eli.bendersky, scoder, serhiy.storchaka, xtreak
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37399] XML text behaviour change if there are comments

[Dima Tisnek]

New submission from Dima Tisnek :

Example:

# mre.py
from xml.etree import ElementTree

XML = "foobar"

a = ElementTree.fromstring(XML)
print(list(a.itertext()))

# Testing 3.7.3 vs. 3.8.0b1; macOS

… ~> python3.7 mre.py
['foobar']
… ~> python3.8 mre.py
['bar']

--
components: Library (Lib)
messages: 346493
nosy: Dima.Tisnek
priority: normal
severity: normal
status: open
title: XML text behaviour change if there are comments
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com