[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset fd32a0e2ee445dd7156323d216627112e66b0a69 by Victor Stinner in 
branch '3.7':
[3.7] bpo-38546: Backport multiprocessing tests fixes from master (GH-19689)
https://github.com/python/cpython/commit/fd32a0e2ee445dd7156323d216627112e66b0a69


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +17110
pull_request: https://github.com/python/cpython/pull/17641

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:

It seems like tests don't leak temporary files anymore:

$ mkdir ~/TEMP
$ TMPDIR=~/TEMP TEMPDIR=~/TEMP ./python -m test -v -r -u all,-gui 
$ ls ~/TEMP
# empty directory

I close the issue.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset cdada40b23b1f7f527797ba7cb14c25820b05981 by Victor Stinner (Miss 
Islington (bot)) in branch '3.8':
bpo-37421: test_concurrent_futures stops ForkServer (GH-14643) (GH-14645)
https://github.com/python/cpython/commit/cdada40b23b1f7f527797ba7cb14c25820b05981


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14456
pull_request: https://github.com/python/cpython/pull/14645

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset e676244235895aeb6ec3b81ca3ccf4a70e487919 by Victor Stinner in 
branch 'master':
bpo-37421: test_concurrent_futures stops ForkServer (GH-14643)
https://github.com/python/cpython/commit/e676244235895aeb6ec3b81ca3ccf4a70e487919


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14455
pull_request: https://github.com/python/cpython/pull/14643

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 229f6e85f8b4d57a2e742e0d3fc361c5bd15f1cb by Miss Islington (bot) 
in branch '3.8':
bpo-37421: multiprocessing tests now stop ForkServer (GH-14601)
https://github.com/python/cpython/commit/229f6e85f8b4d57a2e742e0d3fc361c5bd15f1cb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:

I created a follow-up issue: bpo-37507 "multiprocessing: Add a stop() method to 
ForkServer".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 8fbeb14312b4c1320d31ad86e69749515879d1c3 by Victor Stinner in 
branch 'master':
bpo-37421: multiprocessing tests now stop ForkServer (GH-14601)
https://github.com/python/cpython/commit/8fbeb14312b4c1320d31ad86e69749515879d1c3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14417
pull_request: https://github.com/python/cpython/pull/14602

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:

./python -u -m test test_multiprocessing_spawn -R 3:3 still fail:

ERROR: test_context (test.test_multiprocessing_spawn.TestStartMethod)
ERROR: test_set_get (test.test_multiprocessing_spawn.TestStartMethod)

PR 14601 fix these tests when test_multiprocessing_spawn is run more than once.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14416
pull_request: https://github.com/python/cpython/pull/14601

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 957656ee1d6fb42664274ef2f440a10d26870e2a by Miss Islington (bot) 
in branch '3.8':
bpo-37421: Fix multiprocessing get_temp_dir() finalizer (GH-14572)
https://github.com/python/cpython/commit/957656ee1d6fb42664274ef2f440a10d26870e2a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 2d438fc0b748b64d518ea8876af3f6963c6d7d60 by Miss Islington (bot) 
in branch '3.7':
bpo-37421: Fix multiprocessing get_temp_dir() finalizer (GH-14572)
https://github.com/python/cpython/commit/2d438fc0b748b64d518ea8876af3f6963c6d7d60


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14404
pull_request: https://github.com/python/cpython/pull/14586

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14403
pull_request: https://github.com/python/cpython/pull/14585

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 9d40554e0da09a44a8547f3f3a2b9dedfeaf7928 by Victor Stinner in 
branch 'master':
bpo-37421: Fix multiprocessing get_temp_dir() finalizer (GH-14572)
https://github.com/python/cpython/commit/9d40554e0da09a44a8547f3f3a2b9dedfeaf7928


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14390
pull_request: https://github.com/python/cpython/pull/14572

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 0aefba7f99f0fd9bcb3328a5919e07f9e03676b0 by Miss Islington (bot) 
in branch '3.8':
bpo-37421: Fix test_distutils.test_build_ext() (GH-14564)
https://github.com/python/cpython/commit/0aefba7f99f0fd9bcb3328a5919e07f9e03676b0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 79665c698fb8f97475e03c4231067db1ae47addb by Miss Islington (bot) 
in branch '3.8':
bpo-37421: test_concurrent_futures cleans up multiprocessing (GH-14563)
https://github.com/python/cpython/commit/79665c698fb8f97475e03c4231067db1ae47addb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset a2a807f75dc162dfb45fb297aee4961de8008f84 by Miss Islington (bot) 
in branch '3.8':
bpo-37421: test_winconsoleio doesn't leak temp file anymore (GH-14562)
https://github.com/python/cpython/commit/a2a807f75dc162dfb45fb297aee4961de8008f84


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14389
pull_request: https://github.com/python/cpython/pull/14571

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 74c9dd57771f4f061ee83b069c8e7b37de41246b by Victor Stinner in 
branch 'master':
bpo-37421: Fix test_distutils.test_build_ext() (GH-14564)
https://github.com/python/cpython/commit/74c9dd57771f4f061ee83b069c8e7b37de41246b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14388
pull_request: https://github.com/python/cpython/pull/14570

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 684cb47fffb7af3ac50cb077f6d2a095c9ce20b4 by Victor Stinner in 
branch 'master':
bpo-37421: test_concurrent_futures cleans up multiprocessing (GH-14563)
https://github.com/python/cpython/commit/684cb47fffb7af3ac50cb077f6d2a095c9ce20b4


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14387
pull_request: https://github.com/python/cpython/pull/14569

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset b71d8d67959f3b5efbdfe00066589ac0d8f98aad by Victor Stinner in 
branch 'master':
bpo-37421: test_winconsoleio doesn't leak temp file anymore (GH-14562)
https://github.com/python/cpython/commit/b71d8d67959f3b5efbdfe00066589ac0d8f98aad


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14382
pull_request: https://github.com/python/cpython/pull/14564

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14381
pull_request: https://github.com/python/cpython/pull/14563

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14380
pull_request: https://github.com/python/cpython/pull/14562

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 7cb9204ee1cf204f6f507d99a60f7c5bb359eebb by Victor Stinner in 
branch 'master':
bpo-37421: urllib.request tests call urlcleanup() (GH-14529)
https://github.com/python/cpython/commit/7cb9204ee1cf204f6f507d99a60f7c5bb359eebb


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 632cb36084dc9d13f1cdb31a0e7e3ba80745a51a by Miss Islington (bot) 
in branch '3.8':
bpo-37421: multiprocessing tests call _run_finalizers() (GH-14527)
https://github.com/python/cpython/commit/632cb36084dc9d13f1cdb31a0e7e3ba80745a51a


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 039fb49c185570ab7b02f13fbdc51c859cfd831e by Victor Stinner in 
branch 'master':
bpo-37421: multiprocessing tests call _run_finalizers() (GH-14527)
https://github.com/python/cpython/commit/039fb49c185570ab7b02f13fbdc51c859cfd831e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14372
pull_request: https://github.com/python/cpython/pull/14554

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:

About urllib.request, I created: bpo-37475 "What is urllib.request.urlcleanup() 
function?".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14342
pull_request: https://github.com/python/cpython/pull/14529

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

Change by STINNER Victor :


--
pull_requests: +14340
pull_request: https://github.com/python/cpython/pull/14527

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

miss-islington  added the comment:


New changeset 7fe81ce47ff6725e2e4d667d499e23dac19834af by Miss Islington (bot) 
in branch '3.8':
bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416)
https://github.com/python/cpython/commit/7fe81ce47ff6725e2e4d667d499e23dac19834af


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[miss-islington]

Change by miss-islington :


--
pull_requests: +14230
pull_request: https://github.com/python/cpython/pull/14417

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:


New changeset 4c26abd14f1b7242998eb2f7756aa375e0fe714f by Victor Stinner in 
branch 'master':
bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416)
https://github.com/python/cpython/commit/4c26abd14f1b7242998eb2f7756aa375e0fe714f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37421] Some tests leak temporary files

[STINNER Victor]

STINNER Victor  added the comment:

Using PR 14415, the following test of test_multiprocessing_spawn emits a false 
alarm because multiprocessing use "Finalizer" objects which are only finalized 
"later":
test.test_multiprocessing_spawn.WithManagerTestMyManager.test_mymanager_context_prestarted


Workaround, call explicitly _run_finalizers():

diff --git a/Lib/test/_test_multiprocessing.py 
b/Lib/test/_test_multiprocessing.py
index eef262d723..bfecbab9ee 100644
--- a/Lib/test/_test_multiprocessing.py
+++ b/Lib/test/_test_multiprocessing.py
@@ -5651,6 +5651,7 @@ def install_tests_in_module_dict(remote_globs, 
start_method):
 if need_sleep:
 time.sleep(0.5)
 multiprocessing.process._cleanup()
+multiprocessing.util._run_finalizers()
 test.support.gc_collect()
 
 remote_globs['setUpModule'] = setUpModule

--
title: Tests leak temporary files -> Some tests leak temporary files

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com