[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset 6954be815a16fad11d1d66be576865bbbeb2b97d by Benjamin Peterson 
(Greg Price) in branch 'master':
closes bpo-37758: Extend unicodedata checksum tests to cover all of Unicode. 
(GH-15125)
https://github.com/python/cpython/commit/6954be815a16fad11d1d66be576865bbbeb2b97d


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Thomas Wouters]

Thomas Wouters  added the comment:


New changeset 3cbc23aa229bc5ec04845053df78eae5f54e0497 by T. Wouters (Greg 
Price) in branch 'master':
bpo-37758: Cut always-constant conditionals on sys.maxunicode. (GH-15302)
https://github.com/python/cpython/commit/3cbc23aa229bc5ec04845053df78eae5f54e0497


--
nosy: +twouters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

Change by Greg Price :


--
pull_requests: +15027
pull_request: https://github.com/python/cpython/pull/15302

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

Change by Greg Price :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset def97c988be8340f33869b57942a30d10fc3a1f9 by Benjamin Peterson 
(Greg Price) in branch 'master':
bpo-37758: Clean out vestigial script-bits from test_unicodedata. (GH-15126)
https://github.com/python/cpython/commit/def97c988be8340f33869b57942a30d10fc3a1f9


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

Greg Price  added the comment:

Sent two small PRs!

The first one, GH-15125, makes the substantive test change I described above.

The second one, GH-15126, is a small pure refactor to that test file, just 
cleaning out some bits that made sense when it was first written (as a script) 
but are confusing now that it's a `unittest` test module.  Took me a couple of 
minutes to sort those out when I first dug into this file, and I figure it'd be 
kind to the next person to save them the same effort.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

Change by Greg Price :


--
pull_requests: +14866
pull_request: https://github.com/python/cpython/pull/15126

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

Change by Greg Price :


--
keywords: +patch
pull_requests: +14865
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15125

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37758] unicodedata checksum-tests only test 1/17th of Unicode's codepoints

[Greg Price]

New submission from Greg Price :

The unicodedata module has two test cases which run through the database and 
make a hash of its visible outputs for all codepoints, comparing the hash 
against a checksum.  These are helpful regression tests for making sure the 
behavior isn't changed by patches that didn't intend to change it.

But Unicode has grown since Python first gained support for it, when Unicode 
itself was still rather new.  These test cases were added in commit 6a20ee7de 
back in 2000, and they haven't needed to change much since then... but they 
should be changed to look beyond the Basic Multilingual Plane 
(`range(0x1)`) and cover all 17 planes of Unicode's final form.

Spotted in discussion on GH-15019 
(https://github.com/python/cpython/pull/15019#discussion_r308947884 ).  I have 
a patch for this which I'll send shortly.

--
components: Tests
messages: 349014
nosy: Greg Price
priority: normal
severity: normal
status: open
title: unicodedata checksum-tests only test 1/17th of Unicode's codepoints
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com