[issue37872] Move statitics in Python/import.c to top of the file

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

Keeping this until the PR https://github.com/python/cpython/pull/15057 is 
merged.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37872] Move statitics in Python/import.c to top of the file

[Joannah Nanjekye]

Joannah Nanjekye  added the comment:

Relevant comment from @gnprice.



I think it would be better to make that as a separate change. This style where 
they're block-local is the way the existing code works, which keeps the diff 
simple.

It's also the way that every use of _Py_IDENTIFIER in this file works. So I 
think the cleanest way to change the style would be to sweep through this whole 
file (or more) in one PR, separate from any substantive changes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37872] Move statitics in Python/import.c to top of the file

[Joannah Nanjekye]

New submission from Joannah Nanjekye :

Following a PR review here: https://github.com/python/cpython/pull/15057 by 
@ericsnowcurrently i.e :

Please move both these statics to the top of the file (next to CACHEDIR) as 
globals.

To keep the diff in the above PR simple, I am tracking this refactor in this 
issue.

--
assignee: nanjekyejoannah
components: Library (Lib)
messages: 349859
nosy: eric.snow, nanjekyejoannah, serhiy.storchaka
priority: normal
severity: normal
stage: needs patch
status: open
title: Move statitics in Python/import.c  to top of the file
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com