[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2020-07-20 Thread Vinay Sharma 


Vinay Sharma  added the comment:

Closing this, as all the necessary PRs have been merged.

--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-10 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:


New changeset 2fc1160a80733f4c5c88796319154b3f59e98e4b by Pablo Galindo (Vinay 
Sharma) in branch 'master':
bpo-38018: Fix test for multiprocessing.shared_memory in BSD systems (GH-15821)
https://github.com/python/cpython/commit/2fc1160a80733f4c5c88796319154b3f59e98e4b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Vinay Sharma 


Vinay Sharma  added the comment:

Also, I haven't made a NEWS entry since it's just a short bug fix

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Vinay Sharma 


Vinay Sharma  added the comment:

Hi I have opened another PR: https://github.com/python/cpython/pull/15821
This should fix test failures in FreeBSD.

FreeBSD requires a leading slash in shared memory names. That's why it was 
throwing the below error:

==
ERROR: test_shared_memory_basics 
(test.test_multiprocessing_spawn.WithProcessesTestSharedMemory)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/test/_test_multiprocessing.py",
 line 3737, in test_shared_memory_basics
shm1 = shared_memory.SharedMemory(create=True, size=1)
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/shared_memory.py",
 line 89, in __init__
self._fd = _posixshmem.shm_open(
OSError: [Errno 22] Invalid argument: 'test01_fn'
--

test01_fn doesn't contain a leading slash that's why it is an invalid argument.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Vinay Sharma 


Change by Vinay Sharma :


--
pull_requests: +15469
pull_request: https://github.com/python/cpython/pull/15821

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

Correction, is PR 15662 the one that introduced the recession (the one in this 
issue) not the previous one I linked. Apologies for that.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

This is the failure for reference:

==
ERROR: test_shared_memory_basics 
(test.test_multiprocessing_spawn.WithProcessesTestSharedMemory)
--
Traceback (most recent call last):
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/test/_test_multiprocessing.py",
 line 3737, in test_shared_memory_basics
shm1 = shared_memory.SharedMemory(create=True, size=1)
  File 
"/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/multiprocessing/shared_memory.py",
 line 89, in __init__
self._fd = _posixshmem.shm_open(
OSError: [Errno 22] Invalid argument: 'test01_fn'
--

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Davin Potts 


Davin Potts  added the comment:

Initial review of the test failure suggests a likely flaw in the mechanism used 
by the resource tracker.

I will continue investigating more tomorrow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Pablo Galindo Salgado 


Pablo Galindo Salgado  added the comment:

PR15552 introduced a regression in FreeBSD buildbots:

https://buildbot.python.org/all/#/builders/168/builds/1417

Could you take a look?

--
nosy: +pablogsal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-09 Thread Davin Potts 


Davin Potts  added the comment:


New changeset d14e39c8d9a9b525c7dcd83b2a260e2707fa85c1 by Davin Potts (Vinay 
Sharma) in branch 'master':
bpo-38018: Increase code coverage for multiprocessing.shared_memory (GH-15662)
https://github.com/python/cpython/commit/d14e39c8d9a9b525c7dcd83b2a260e2707fa85c1


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-03 Thread Vinay Sharma 


Vinay Sharma  added the comment:

Can anyone please review my pull request. No Reviewer has been assigned yet to 
it. And I don't have permissions to request a review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-03 Thread Vinay Sharma 


Change by Vinay Sharma :


--
keywords: +patch
pull_requests: +15327
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15662

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-03 Thread Karthikeyan Singaravelan 


Change by Karthikeyan Singaravelan :


--
nosy: +davin

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38018] Increase Code Coverage for multiprocessing.shared_memory

2019-09-03 Thread Vinay Sharma 


New submission from Vinay Sharma :

Increase Code coverage for multiprocessing.shared_memory.SharedMemory Class

--
components: Tests
messages: 351085
nosy: vinay0410
priority: normal
severity: normal
status: open
title: Increase Code Coverage for multiprocessing.shared_memory
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com