[issue38066] Hide internal asyncio.Stream methods

[tzickel]

tzickel  added the comment:

The documentation needs to scrub this methods as well, for example:

https://docs.python.org/3/library/asyncio-stream.html#asyncio.StreamReader.at_eof

still mentions them.

--
nosy: +tzickel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[miss-islington]

miss-islington  added the comment:


New changeset f12ff05bc07ac087743a4615c4af5f66b73f8d2c by Miss Islington (bot) 
in branch '3.8':
bpo-38066: Hide internal Stream methods (GH-15762)
https://github.com/python/cpython/commit/f12ff05bc07ac087743a4615c4af5f66b73f8d2c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[miss-islington]

Change by miss-islington :


--
pull_requests: +15493
pull_request: https://github.com/python/cpython/pull/15847

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[miss-islington]

miss-islington  added the comment:


New changeset 12c122ae958a55c9874ed4c7d7805ceb084411d7 by Miss Islington (bot) 
(Andrew Svetlov) in branch 'master':
bpo-38066: Hide internal Stream methods (GH-15762)
https://github.com/python/cpython/commit/12c122ae958a55c9874ed4c7d7805ceb084411d7


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Done.
The only API from transport that users really need is get_extra_info() which is 
exposed as a stream method already.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[Yury Selivanov]

Yury Selivanov  added the comment:

BTW, if we are doing this -- maybe not expose the underlying transport at all?  
I don't like that we do that currently, and there multiple ways for the user to 
screw up the Stream object (and potentially break start_tls()/sendfile() etc)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[Andrew Svetlov]

Change by Andrew Svetlov :


--
keywords: +patch
pull_requests: +15415
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/15762

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38066] Hide internal asyncio.Stream methods

[Andrew Svetlov]

New submission from Andrew Svetlov :

As discussed in discussion 
https://github.com/python/cpython/pull/14488#discussion_r322176319

Hide feed_eof(), feed_data(), set_exception() and set_transport() methods.

--
components: asyncio
messages: 351433
nosy: asvetlov, yselivanov
priority: normal
severity: normal
status: open
title: Hide internal asyncio.Stream methods
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com