[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

Change by Lisa Roach :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

Lisa Roach  added the comment:


New changeset b76ab352405df105c2d459fc66ef8dc98e47b37c by Lisa Roach (Miss 
Islington (bot)) in branch '3.8':
bpo-38108: Makes mock objects inherit from Base (GH-16060) (GH-16470)
https://github.com/python/cpython/commit/b76ab352405df105c2d459fc66ef8dc98e47b37c


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[miss-islington]

Change by miss-islington :


--
pull_requests: +16053
pull_request: https://github.com/python/cpython/pull/16470

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

Lisa Roach  added the comment:


New changeset 9a7d9519506ae807ca48ff02e2ea117ebac3450e by Lisa Roach in branch 
'master':
bpo-38108: Makes mock objects inherit from Base (GH-16060)
https://github.com/python/cpython/commit/9a7d9519506ae807ca48ff02e2ea117ebac3450e


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

Change by Lisa Roach :


--
keywords: +patch
pull_requests: +15683
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16060

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

Lisa Roach  added the comment:

Also:

_AsyncIterator
_AwaitEvent

Some of the code in AsyncMagicMixin might be able to be simplified if we 
inherit from MagicMixin instead, right now we might be duplicating work.

In general we have to watch out for duplication/overwriting of attributes with 
this change.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38108] Everything in Mock should inherit from Base

[Lisa Roach]

New submission from Lisa Roach :

Everything within Mock should be inheriting from the top-level parent class, 
Base (and properly call super).

For multiple inheritance to work correctly they all should be inheriting from 
the same parent class ultimately. 

Classes that need update:

MagicMixin
AsyncMagicMixin
NonCallableMock (instance = object.__new__(new) should be switched to a super 
call here)

--
assignee: lisroach
messages: 351863
nosy: ezio.melotti, lisroach, michael.foord, xtreak
priority: normal
severity: normal
status: open
title: Everything in Mock should inherit from Base
versions: Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com