[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Eric Snow]

Change by Eric Snow :


--
status: pending -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Eric Snow]

Change by Eric Snow :


--
assignee:  -> eric.snow
resolution:  -> fixed
stage: patch review -> resolved
status: open -> pending

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Eric Snow]

Eric Snow  added the comment:


New changeset 6693f730e0eb77d9453f73a3da33b78a97e996ee by Eric Snow in branch 
'master':
bpo-38187: Fix a refleak in Tools/c-analyzer. (gh-16304)
https://github.com/python/cpython/commit/6693f730e0eb77d9453f73a3da33b78a97e996ee


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Eric Snow]

Change by Eric Snow :


--
pull_requests: +15890
pull_request: https://github.com/python/cpython/pull/16304

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

PR 16233 fixes the reference leaks but the original error is still present and

./python -m test test_tools -v -R 3:3

is still failing (as in the test fails, instead of failing because there are 
leaks).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
Removed message: https://bugs.python.org/msg352645

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

The original error is still present and

./python -m test test_tools -v -R 3:3

is still failing some times, but when it suceeds there are no leaks being 
reported.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:


New changeset 6fbc924696b4b5097c273c06ca2d82662940e184 by Pablo Galindo in 
branch 'master':
bpo-38187: Fix reference leak in test_tools (GH-16233)
https://github.com/python/cpython/commit/6fbc924696b4b5097c273c06ca2d82662940e184


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +15830
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16233

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[STINNER Victor]

STINNER Victor  added the comment:

I also opened https://bugs.python.org/issue38177#msg352474 we should only track 
this leak in a single issue, you can close bpo-38177.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
nosy: +nanjekyejoannah, vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Check this failure in the buildbots for reference:

https://buildbot.python.org/all/#/builders/80/builds/705/steps/4/logs/stdio

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38187] test.test_tools.test_c_analyzer fails in refleak mode

[Pablo Galindo Salgado]

New submission from Pablo Galindo Salgado :

Running the test suite to check refleaks over test.test_tools.test_c_analyzer 
will always fail, make it impossible for the refleak buildbots to run 
correctly. 

Steps to reproduce:

./python -m test test_tools -v -R 3:3


==
FAIL: test_typical 
(test.test_tools.test_c_analyzer.test_c_globals.test_find.StaticsTest)
--
Traceback (most recent call last):
  File 
"/home/pablogsal/github/cpython/Lib/test/test_tools/test_c_analyzer/test_c_globals/test_find.py",
 line 319, in test_typical
self.assertEqual(found, [
AssertionError: Lists differ: [Vari[413 chars]rc1/sub/ham.c', funcname=None, 
name='var1'), v[318 chars]nt')] != [Vari[413 chars]rc1/spam.c', funcname=None, 
name='freelist'), [431 chars]nt')]

First differing element 4:
Varia[21 chars]rc1/sub/ham.c', funcname=None, name='var1'), v[30 chars]t *')
Varia[21 chars]rc1/spam.c', funcname=None, name='freelist'), [34 chars]10]')

Second list contains 1 additional elements.
First extra element 8:
Variable(id=ID(filename='Include/spam.h', funcname=None, name='data'), 
vartype='static const int')

  [Variable(id=ID(filename='src1/spam.c', funcname=None, name='var1'), 
vartype='static const char *'),
   Variable(id=ID(filename='src1/spam.c', funcname='ham', name='initialized'), 
vartype='static int'),
   Variable(id=ID(filename='src1/spam.c', funcname=None, name='var2'), 
vartype='static PyObject *'),
   Variable(id=ID(filename='src1/eggs.c', funcname='tofu', name='ready'), 
vartype='static int'),
+  Variable(id=ID(filename='src1/spam.c', funcname=None, name='freelist'), 
vartype='static (PyTupleObject *)[10]'),
   Variable(id=ID(filename='src1/sub/ham.c', funcname=None, name='var1'), 
vartype='static const char const *'),
   Variable(id=ID(filename='src2/jam.c', funcname=None, name='var1'), 
vartype='static int'),
   Variable(id=ID(filename='src2/jam.c', funcname=None, name='var2'), 
vartype='static MyObject *'),
   Variable(id=ID(filename='Include/spam.h', funcname=None, name='data'), 
vartype='static const int')]

--

Ran 219 tests in 3.769s

FAILED (failures=1, skipped=2, expected failures=14)
test test_tools failed
test_tools failed

== Tests result: FAILURE ==

1 test failed:
test_tools

Total duration: 19 sec 101 ms
Tests result: FAILURE

--
components: Tests
messages: 352552
nosy: eric.snow, pablogsal
priority: normal
severity: normal
status: open
title: test.test_tools.test_c_analyzer fails in refleak mode
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com