[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Ronald Oussoren


Ronald Oussoren  added the comment:

W.r.t. the deprecated APIs in getpath.c: Issue15498

That issue contains an ancient patch to switch to non-deprecated APIs, but we 
haven't had time yet to fully test these. The issue also mentions that Apple's 
install of Python already switched away from the deprecated APIs, but had some 
issues at the time.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor


STINNER Victor  added the comment:

Thanks for the bug report Haruka Ma, it should now be fixed.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor


STINNER Victor  added the comment:


New changeset b6e0fc74265db96fdd0e0b8151c768c583ad80f0 by Victor Stinner in 
branch 'master':
bpo-38353: Fix typos in calculate_argv0_path_framework() (GH-16695)
https://github.com/python/cpython/commit/b6e0fc74265db96fdd0e0b8151c768c583ad80f0


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor


STINNER Victor  added the comment:

Hum, getpath.c seems to use deprecated APIs:

./Modules/getpath.c:1098:20: warning: 'NSModuleForSymbol' is deprecated: first 
deprecated in macOS 10.5 - dladdr() [-Wdeprecated-declarations]
pythonModule = NSModuleForSymbol(NSLookupAndBindSymbol("_Py_Initialize"));
   ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach-o/dyld.h:193:21:
 note: 'NSModuleForSymbol' has been explicitly marked deprecated here
extern NSModule NSModuleForSymbol(NSSymbol symbol) __API_UNAVAILABLE(ios, 
tvos, watchos)  __OSX_DEPRECATED(10.1, 10.5, "dladdr()");
^
./Modules/getpath.c:1098:38: warning: 'NSLookupAndBindSymbol' is deprecated: 
first deprecated in macOS 10.4 - dlsym() [-Wdeprecated-declarations]
pythonModule = NSModuleForSymbol(NSLookupAndBindSymbol("_Py_Initialize"));
 ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach-o/dyld.h:183:17:
 note: 'NSLookupAndBindSymbol' has been explicitly marked deprecated here
extern NSSymbol NSLookupAndBindSymbol(const char* symbolName)   
 __API_UNAVAILABLE(ios, tvos, watchos)  
__OSX_DEPRECATED(10...
^
./Modules/getpath.c:1101:27: warning: 'NSLibraryNameForModule' is deprecated: 
first deprecated in macOS 10.5 [-Wdeprecated-declarations]
const char* modPath = NSLibraryNameForModule(pythonModule);
  ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/mach-o/dyld.h:163:21:
 note: 'NSLibraryNameForModule' has been explicitly marked deprecated here
extern const char*  NSLibraryNameForModule(NSModule m) __API_UNAVAILABLE(ios, 
tvos, watchos)  __OSX_DEPRECATED(10.1, 10.5, "");
^
3 warnings generated.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Haruka Ma


Haruka Ma  added the comment:

I'm now getting double free on the same function:

https://pastebin.com/zHWCtTuV (with debug on)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor


STINNER Victor  added the comment:

Oh, I expected that we had macOS buildbots building Python with 
--enable-framework. Thanks for the reporting the issue.

I wrote PR 16695 which should fix the issue, but I cannot test my fix right now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread STINNER Victor


Change by STINNER Victor :


--
keywords: +patch
pull_requests: +16282
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/16695

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Ned Deily


Change by Ned Deily :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue38429] Failed to compile with --enable-framework on macOS on master

2019-10-10 Thread Haruka Ma


New submission from Haruka Ma :

Since commit 
https://github.com/python/cpython/commit/c02b41b1fb115c87693530ea6a480b2e15460424
 , some syntax errors are preventing cpython from compiling with 
--enable-framework on. 

Specifically, the errors are in Modules/getpath.c on line 1134 and 1165.

I've made some inline comments on github as well.

--
components: macOS
messages: 354348
nosy: Haruka Ma, ned.deily, ronaldoussoren
priority: normal
severity: normal
status: open
title: Failed to compile with --enable-framework on macOS on master
type: compile error
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com