[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[miss-islington]

miss-islington  added the comment:


New changeset 755caaa753577b907bb7e94560f8adf5eb694d6b by Miss Islington (bot) 
in branch '3.7':
bpo-38636: Fix IDLE tab toggle and file indent width (GH-17008)
https://github.com/python/cpython/commit/755caaa753577b907bb7e94560f8adf5eb694d6b


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[miss-islington]

miss-islington  added the comment:


New changeset 132243957ce834cf5ffced4bf8e39d00f6e34e5f by Miss Islington (bot) 
in branch '3.8':
bpo-38636: Fix IDLE tab toggle and file indent width (GH-17008)
https://github.com/python/cpython/commit/132243957ce834cf5ffced4bf8e39d00f6e34e5f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +16768
pull_request: https://github.com/python/cpython/pull/17275

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset b8462477bfd01ff21461065d5063e6b0238ca809 by Terry Jan Reedy in 
branch 'master':
bpo-38636: Fix IDLE tab toggle and file indent width (GH-17008)
https://github.com/python/cpython/commit/b8462477bfd01ff21461065d5063e6b0238ca809


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[miss-islington]

Change by miss-islington :


--
pull_requests: +16767
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/17274

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The old, long discussion of Shell indents is #7676 and a preceding issue 
reference therein.  My replacement is #37892.

The PR patch is simple enough to apply by to existing 3.7.5 and 3.8.0 installs.

--
stage: patch review -> test needed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Change by Terry J. Reedy :


--
keywords: +patch
pull_requests: +16533
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/17008

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Interesting.  The result of making these changes is legal code looking like
>>> if a:
if b:
c = 3
This has been proposed as the way Shell should work, but rejected as likely too 
confusing to beginners as the indented code does not look indented compared to 
the line above.  The use of tabs for indents in Shell has long been considered 
a wart that is a 'least bad solution'.

Please hold your proposals.  I intend to solve the issue by moving the prompt 
to a shell sidebar and use the same indent in shell as in editors.  #37903 has 
a PR under review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Stephen Paul Chappell]

Stephen Paul Chappell  added the comment:

When I start IDLE and the shell window appears, my first task is to press "Alt 
+ T" to change from using tabs to spaces and then "Alt + U" to change from 
using 8 spaces to 4. This allows code pasted from the shell into an editor 
window or other IDE to not require reformatting since those settings seem to be 
common for Python code. If the defaults for these settings were to be exposed 
in IDLE's settings under the General tab (maybe near the new "Show line numbers 
in new windows" checkbox), would it be best to make that request here or to 
open a new bug with an enhancement suggestion?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38636] IDLE regression: toggle tabs and change indent width functions

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Both the menu items and the short cuts for these two functions on the Format 
menu give these call errors.  They are only visible if IDLE is started from a 
console.

They work in 3.6; the regression is due to #36390.  These 2 functions were 
moved separately from the others in the 3rd PR, PR 14827, changeset 
1b3892243433da7eae7f5f3a4f98f13d309c8926.  I found the mistake and believe I 
have one possible version of a working fix on a new branch.

The diff contains this comment:
  # With mixed indents not allowed, these are semi-useless and not unittested.
I was thinking that they should be removed, but regardless, they should have 
been manually tested.  However, in one test with 3.6, a mixed indent -- tab + 4 
spaces following a 4 space tab -- did work, so I am not sure of the rule.  I 
will try to add a unittest along with the fix.

--
components:  -Windows
nosy:  -paul.moore, steve.dower, tim.golden, zach.ware
stage:  -> test needed
title: "Alt + T" and "Alt + U" Broken in IDLE on Windows -> IDLE regression: 
toggle tabs and change indent width functions
versions: +Python 3.7, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com