[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

Thanks for the fix Eddie Elizondo!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[Benjamin Peterson]

Benjamin Peterson  added the comment:


New changeset e4db1f05e9a5828f6b287f99067362fa0e5732e8 by Benjamin Peterson 
(Eddie Elizondo) in branch 'master':
closes bpo-38803: Fix leak in posixmodule. (GH-17373)
https://github.com/python/cpython/commit/e4db1f05e9a5828f6b287f99067362fa0e5732e8


--
nosy: +benjamin.peterson
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[Eddie Elizondo]

Eddie Elizondo  added the comment:

Victor, the PR with the fix is out. Easy catch after running it with my leak 
detector!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[Eddie Elizondo]

Change by Eddie Elizondo :


--
keywords: +patch
pull_requests: +16856
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17373

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[Eddie Elizondo]

Eddie Elizondo  added the comment:

Woops! I'll get to it before the end of the weekend!

--
nosy: +eelizondo

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

STINNER Victor  added the comment:

Similar failure on other buildbot workers.

AMD64 RHEL7 Refleaks 3.x:
https://buildbot.python.org/all/#/builders/264/builds/49

AMD64 Fedora Stable Refleaks 3.x:
https://buildbot.python.org/all/#/builders/317/builds/42

AMD64 Fedora Rawhide Refleaks 3.x:
https://buildbot.python.org/all/#/builders/189/builds/197

AMD64 RHEL8 Refleaks 3.x:
https://buildbot.python.org/all/#/builders/272/builds/50

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38803] test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x

[STINNER Victor]

New submission from STINNER Victor :

x86 Gentoo Refleaks 3.x, first failure:
https://buildbot.python.org/all/#/builders/1/builds/769

test_wait3 leaked [23, 23, 23] references, sum=69
test_wait4 leaked [22, 21, 22] references, sum=65


The leak was introduced by:

commit b3966639d28313809774ca3859a347b9007be8d2
Author: Eddie Elizondo 
Date:   Tue Nov 5 07:16:14 2019 -0800

bpo-35381 Remove all static state from posixmodule (GH-15892)



After #9665, this moves the remaining types in posixmodule to be 
heap-allocated to make it compatible with PEP384 as well as modifying all the 
type accessors to fully make the type opaque.

The original PR that got messed up a rebase: 
https://github.com/python/cpython/pull/10854. All the issues in that commit 
have now been addressed since https://github.com/python/cpython/pull/11661 got 
committed.

This change also removes any state from the data segment and onto the 
module state itself.


https://bugs.python.org/issue35381



Automerge-Triggered-By: @encukou

--
components: Tests
messages: 356633
nosy: vstinner
priority: normal
severity: normal
status: open
title: test_wait3 and test_wait4 leaked references on x86 Gentoo Refleaks 3.x
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com