[issue38863] Improve is_cgi() in http.server

[Rhodri James]

Change by Rhodri James :


--
nosy:  -Rhodri James

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Siwon Kang]

Siwon Kang  added the comment:

Obviously, I should have taken back what I added to cgi_directories. Thank you 
Pablo and Victor!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Andrew Svetlov]

Andrew Svetlov  added the comment:

Thanks, Pablo!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[STINNER Victor]

STINNER Victor  added the comment:

The change introduced a reference leak, see bpo-38962. Pablo fixed it:

commit 24f5cac7254177a4c9956d680c0a9b6dadd85c6f (HEAD -> master, 
upstream/master)
Author: Pablo Galindo 
Date:   Wed Dec 4 09:29:10 2019 +

bpo-38962: Fix reference leak in test_httpservers (GH-17454)

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Andrew Svetlov]

Change by Andrew Svetlov :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[miss-islington]

miss-islington  added the comment:


New changeset 91daa9d7224626dad4bb820924c01b3438ca6e3f by Miss Islington (bot) 
(Siwon Kang) in branch 'master':
bpo-38863: Improve is_cgi() in http.server (GH-17312)
https://github.com/python/cpython/commit/91daa9d7224626dad4bb820924c01b3438ca6e3f


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Dong-hee Na]

Change by Dong-hee Na :


--
nosy: +Rhodri James, ethan.furman -corona10

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Dong-hee Na]

Dong-hee Na  added the comment:

@martin.panter, @asvetlov

I add the core developers who looks like to be experts on this module.
Can you follow up on Siwon's PR?

Thanks for your understanding.

--
nosy: +asvetlov, martin.panter
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Dong-hee Na]

Dong-hee Na  added the comment:

Thanks, Siwon Kang, I now understood what you want to say.
I left some comments on your PR 17312.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38863] Improve is_cgi() in http.server

[Siwon Kang]

Siwon Kang  added the comment:

Hi Donghee,
Since you said this is not a bug, I changed the title describing this is a 
matter of improvement.

For your comment, I would say sorry first that I have made you confused. My 
mention about apache is just to give you an example for the other module that 
does similar thing(HTTP request handler with cgi support). I would never say 
the Python server shall support the sub-directory parsing for cgi scripts 
because apache does but I am saying good is good.

>> Yes, IMHO, but this code is related to the http.server.CGIHTTPRequestHandler.
This code looks like to be executed on the http.server.CGIHTTPRequestHandler 
not the apache server.

So you may see the PR changes the CGIHTTPRequestHandler class. Please refer to 
the code.

>> According to docs,
This defaults to ['/cgi-bin', '/htbin'] and describes directories to treat as 
containing CGI scripts.

This is the one I was looking at. As described, I added '/sub/dir/cgi-bin' into 
the cgi_directories expecting it to be treated the directory is for CGI scripts 
but the CGIHTTPRequestHandler does not process it. That is the reason for this 
issue report. Again, there is no note that restrict the path in cgi_directories 
shall be a single depth, so I think this will definitely give a benefit to 
handle the multi-level directories just like https://bugs.python.org/issue21323 
enables processing the sub directories of /cgi-bin.
Does this make sense to you now?

--
title: http.server is_cgi() does not correctly separate dir -> Improve is_cgi() 
in http.server
type: behavior -> enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com