[issue39019] Missing class getitems in standard library classes

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:

> Hold on, os.DirEntry[str] still doesn't work.

That is what I asked on the issue 39481. I couldn't find anything about its 
cover on PEP 585.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Guido van Rossum]

Guido van Rossum  added the comment:

Hold on, os.DirEntry[str] still doesn't work.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan Taskaya]

Change by Batuhan Taskaya :


--
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan Taskaya]

Batuhan Taskaya  added the comment:

PEP 585 is landed, closing the issue (and linked PRs)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests:  -17994

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
nosy: +serhiy.storchaka
nosy_count: 4.0 -> 5.0
pull_requests: +17994
pull_request: https://github.com/python/cpython/pull/18629

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:

> Once PEP 585 is implemented these should be rolled back and replaced with 
> that, right?

I would say that ideally yes.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Guido van Rossum]

Guido van Rossum  added the comment:

Once PEP 585 is implemented these should be rolled back and replaced with that, 
right?

--
nosy: +gvanrossum

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset 09c482fad11c769be38b2449f1056e264b701bb7 by Ivan Levkivskyi 
(Batuhan Taşkaya) in branch 'master':
bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile 
(GH-17560)
https://github.com/python/cpython/commit/09c482fad11c769be38b2449f1056e264b701bb7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Ivan Levkivskyi]

Ivan Levkivskyi  added the comment:


New changeset 4dc5a9df59837446ec1dc5b7a0e6ce95ae5b5cec by Ivan Levkivskyi 
(Batuhan Taşkaya) in branch 'master':
bpo-39019: Implement missing __class_getitem__ for subprocess classes (GH-17558)
https://github.com/python/cpython/commit/4dc5a9df59837446ec1dc5b7a0e6ce95ae5b5cec


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

Change by Batuhan :


--
pull_requests: +17035
pull_request: https://github.com/python/cpython/pull/17563

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

Change by Batuhan :


--
pull_requests: +17033
pull_request: https://github.com/python/cpython/pull/17561

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

Change by Batuhan :


--
pull_requests: +17032
pull_request: https://github.com/python/cpython/pull/17560

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

Change by Batuhan :


--
keywords: +patch
pull_requests: +17030
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17558

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

Change by Batuhan :


--
components: +Library (Lib)
nosy: +levkivskyi
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39019] Missing class getitems in standard library classes

[Batuhan]

New submission from Batuhan :

After working on issue 38994 and issue 38978, I decided to write a simple AST 
analyzer to find class getitem syntax usage in typeshed. It discovered a few 
classes (I am not sure if there are more). As @brett.cannon suggested in PR 
17498 I'll prepare individual pull requests.  

typeshed/stdlib/3/subprocess.pyi:868  => Popen
typeshed/stdlib/3/subprocess.pyi:82   => CompletedProcess
typeshed/stdlib/3/tempfile.pyi:98 => SpooledTemporaryFile
typeshed/stdlib/3/os/__init__.pyi:463 => DirEntry
typeshed/stdlib/3/http/cookies.pyi:5  => Morsel

--
messages: 358209
nosy: BTaskaya, brett.cannon
priority: normal
severity: normal
status: open
title: Missing class getitems in standard library classes

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com