[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Ned Deily]

Ned Deily  added the comment:

We might as well close this for now. I'm hoping for an 8.6.11 real soon now 
with almost a year's worth of changes, many for macOS, and we will need to 
incorporate it all into a revised installer variant. It won't be forgotten :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The Windows part of this is done.  Existing tests also pass on my machine.

Ned, do you want this left open for macOS? or close?

--
stage: patch review -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Steve Dower  added the comment:


New changeset 985f0ab3ad5e8e9a8d7fc53026c38390b1f2b466 by Steve Dower in branch 
'master':
bpo-39107: Updated Tcl and Tk to 8.6.10 in Windows installer (GH-22405)
https://github.com/python/cpython/commit/985f0ab3ad5e8e9a8d7fc53026c38390b1f2b466


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Ned Deily]

Ned Deily  added the comment:

The ScaleTest failure is the subject of Issue41306 and PR 21715.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Steve Dower  added the comment:

> PR branches on the main repository are discouraged.

I had another reason, which was that I needed to trigger a signed build of the 
separate Tcl and Tk binaries. This is much easier (and safer) to do from the 
main repo than my own fork.

But yeah, in general (for anyone else reading this), PRs from forks are fine. 
Tcl/Tk are special.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Terry J. Reedy]

Terry J. Reedy  added the comment:

On Windows, tk Scale['from'] is no longer rounded, matching ttk.Scale.  More 
details and conditional fix on the PR.

--
versions: +Python 3.10 -Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Terry J. Reedy]

Terry J. Reedy  added the comment:

The existing patch mostly changes '9' to '10', which cannot in itself cause the 
test failure.  There must be a change in widget behavior.  Either Serhiy or 
Mark Rosemen might do better at diagnosing the discrepancy and whether 
_tkinter.c, tkinter.__init__, or tkinter/.../test_widget.py should be changed.
--

PR branches on the main repository are discouraged.  It is just as easy and 
safer for another coredev to modify a fork branch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Steve Dower  added the comment:

(My PR is from a branch in the main repo, so if you want to just go in and fix 
it, feel free.)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Steve Dower  added the comment:

I did a build for Windows and put up the PR taking it in and there seems to be 
one (related) test failure:

==
FAIL: test_from (tkinter.test.test_tkinter.test_widgets.ScaleTest)
--
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\tkinter\test\test_tkinter\test_widgets.py", 
line 943, in test_from
self.checkFloatParam(widget, 'from', 100, 14.9, 15.1, conv=float_round)
  File "D:\a\cpython\cpython\lib\tkinter\test\widget_tests.py", line 106, in 
checkFloatParam
self.checkParam(widget, name, value, conv=conv, **kwargs)
  File "D:\a\cpython\cpython\lib\tkinter\test\widget_tests.py", line 63, in 
checkParam
self.assertEqual2(widget[name], expected, eq=eq)
  File "D:\a\cpython\cpython\lib\tkinter\test\widget_tests.py", line 47, in 
assertEqual2
self.assertEqual(actual, expected, msg)
AssertionError: 14.9 != 15.0

Terry, any ideas?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +21445
pull_request: https://github.com/python/cpython/pull/22405

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Mark Roseman]

Change by Mark Roseman :


--
nosy: +markroseman

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Aivar Annamaa]

Aivar Annamaa  added the comment:

According to the comments under https://github.com/python/cpython/pull/18982 
there is no point in creating a PR, so I'll just share my experiences.

I was able to build current master with Tcl/Tk 8.6.10 both on Windows 10 
(64-bit) and on macOS Catalina. I ran the tests on Windows and no 
Tkinter-related tests failed. I tested it manually on both platforms by poking 
around in IDLE and Thonny IDE and saw no (big) issues. (The only regression I 
saw in Thonny was Toplevel tooltips gaining a title bar, but I could solve it 
by adding a "wm_overrideredirect(1)"). 

One of the new features on macOS -- support for dark mode -- looked nice. 
Half-baked emoji support had not regressed at least.

I really hope you'll find time to include Tk 8.6.10 in the last beta of Python 
3.9!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[szb512]

szb512  added the comment:

That backfired horribly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Ido Michael]

Change by Ido Michael :


--
nosy:  -Ido Michael

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[szb512]

szb512  added the comment:

I'll update my PR to include some changes for windows.

--
nosy: +alittleman512

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Steve Dower]

Steve Dower  added the comment:

Yeah, this is on me now. Hopefully we can just pull in the new sources and 
they'll be fine, but historically it's taken a couple of days/weeks to get the 
issues ironed out.

Unfortunately, I'm still on a flaky internet connection (but only for 
GitHub.com for some reason), so I can't clone the repos I need. But someone 
else should be able to submit PRs that I can merge:

* clone https://github.com/python/cpython-source-deps/
* disable autocrlf
* checkout tcl, delete all files (except README.md) and extract tcl-8.6.10
* git add --all; git tag tcl-core-8.6.10.0; push and send PR
* checkout tk, delete all files (except README.md) and extract tk-8.6.10
* git add --all; git tag tk-8.6.10.0; push and send PR

Once those are merged:
* checkout cpython repo and update version number in PCbuild/tcltk.props and 
PCbuild/get_externals.bat
* test build with PCbuild/prepare_tcltk.bat, then build with PCbuild/build.bat
* push, send PR

Before that is merged, I'll branch in cpython-bin-deps so that PRs keep 
building with the older version, then I can trigger the real build. I'll likely 
need somebody to download the built files and check them into the 
cpython-bin-deps repo, but I'll give it a go myself first in case my connection 
is up to it.

Any volunteers?

--
assignee: ned.deily -> steve.dower

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Ned Deily]

Ned Deily  added the comment:

There is nothing more for you to do for this on the Mac side right now, thanks. 
 I’m not sure what the Status of changes for Windows build are.  Perhaps that 
should be a separate issue as the two aren’t really related.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Ido Michael]

Ido Michael  added the comment:

I can take this for Mac V 10.14.6 if there was a decision?

--
nosy: +Ido Michael

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[szb512]

Change by szb512 :


--
keywords: +patch
nosy: +sdcards
nosy_count: 9.0 -> 10.0
pull_requests: +18330
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18982

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39107] Upgrade tcl/tk to 8.6.10 (Windows and maxOS)

[Terry J. Reedy]

Terry J. Reedy  added the comment:

https://www.tcl.tk/man/tcl8.6/TkCmd/contents.htm now displays the 8.6.10 pages, 
so the tcl folk consider this to be the current stable release.

Zach or Steve or whowever can handle this for Windows, please upgrade pcbuild 
and whatever else 'soon' (by next release?).  I have looked at
https://sourceforge.net/projects/tcl/files/Tcl/8.6.10/tcltk-release-notes-8.6.10.txt/view
and would like to check out one POTENTIAL INCOMPATIBILITY (mousewheel bindings) 
and a couple of new features.

--
nosy: +serhiy.storchaka
priority: normal -> high
title: Consider building Tkinter with Tk 8.6.10 -> Upgrade tcl/tk to 8.6.10 
(Windows and maxOS)
versions:  -Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com