[issue3911] ftplib.FTP.makeport() bug
Benjamin Peterson [EMAIL PROTECTED] added the comment: Fixed in r66656. -- priority: - release blocker resolution: - fixed status: open - closed ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3911] ftplib.FTP.makeport() bug
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: Would you like to contribute a patch? Done in issue #3939. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3911] ftplib.FTP.makeport() bug
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: Would you like to contribute a patch? Ok. I started working on a patch which implements a dummy asyncore-based FTP server including tests for all basic FTP() class methods. I'll contribute a patch as soon as I'll wrote IPv6 tests. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3911] ftplib.FTP.makeport() bug
Benjamin Peterson [EMAIL PROTECTED] added the comment: Why not just use floor divide (//)? -- nosy: +benjamin.peterson ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3911] ftplib.FTP.makeport() bug
Giampaolo Rodola' [EMAIL PROTECTED] added the comment: At your discretion. I was thinking that it's not encouraging that such an outstanding bug has passed silently until RC1. IMHO, a minimal test suite for the ftplib module would be really necessary. A dummy FTP server returning fixed response codes could be arranged and used to test the basic FTP class methods. ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3911] ftplib.FTP.makeport() bug
Benjamin Peterson [EMAIL PROTECTED] added the comment: On Fri, Sep 19, 2008 at 6:23 PM, Giampaolo Rodola' [EMAIL PROTECTED] wrote: Giampaolo Rodola' [EMAIL PROTECTED] added the comment: At your discretion. I was thinking that it's not encouraging that such an outstanding bug has passed silently until RC1. IMHO, a minimal test suite for the ftplib module would be really necessary. Yes, testing of some of these modules is quite sad. A dummy FTP server returning fixed response codes could be arranged and used to test the basic FTP class methods. Would you like to contribute a patch? ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python tracker [EMAIL PROTECTED] http://bugs.python.org/issue3911 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
