[issue3926] Idle doesn't obey the new improved warnings arguements

[Guilherme Polo]

Guilherme Polo  added the comment:

> Committed on r74447, will merge into py3k.

py3k: r74450

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Guilherme Polo]

Guilherme Polo  added the comment:

Committed on r74447, will merge into py3k.

--
resolution:  -> accepted
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Guilherme Polo]

Guilherme Polo  added the comment:

This looks good Scott, I'm just attaching the .diff here with real minor
changes and will be applying if no one is against it.

--
keywords: +patch
Added file: http://bugs.python.org/file14638/idle_fixwarnings.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Scott David Daniels]

Scott David Daniels <[EMAIL PROTECTED]> added the comment:

Attached parts.zip -- a zip of updates for Python 2.6 and Python 3.0
against the current source [zip has two 

For Python 2.6:
py26/diff_py26.txt  -- differ against python26-maint tree
py26/PyShell.py -- Replacement file for .../Lib/idlelib/PyShell.py
py26/run.py -- Replacement file for .../Lib/idlelib/run.py

For Python 3.0:
py30/py3k_diff.txt  -- differ against python3k tree
py30/PyShell.py -- Replacement file for .../Lib/idlelib/PyShell.py
py30/run.py -- Replacement file for .../Lib/idlelib/run.py

Added file: http://bugs.python.org/file12113/parts.zip

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

This is already corrected by r66922 (issue3391), but the patches are
different and there are some things I don't like in the present
implementation:

- in idle_showwarning, the "file" argument is ignored and always
replaced by warning_stream.
- warnings.formatwarning is passed a "file" argument: this could fail,
but works only because the function is monkey-patched. But "file" is not
even used there!

The attached patch seems better, but does not apply cleanly any more.

--
nosy: +amaury.forgeotdarc

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Scott David Daniels]

Scott David Daniels <[EMAIL PROTECTED]> added the comment:

Here is a test for the fixes provided.

Added file: http://bugs.python.org/file11637/test_idle_warnings.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Scott David Daniels]

Scott David Daniels <[EMAIL PROTECTED]> added the comment:

OK, Issues:
1) warnings.py 
I/O errors in formatwarning will be masked and misinterpreted as
failures to write on stderr, and no output will be attempted.  

2) warnings.py
A line with of whitespace will be shown, rather than suppressed.

3) idlelib/PyShell.py 
idle_show_warning did not take new args to showwarning.
& a repeat of an error much like 1.

3) idlelib/PyShell.py
idle_format_warning did not take new arg to formatwarning.

4) idlelib/PyShell.py
extended_linecache_checkcache did not pass its arg along to 
orig_checkcache.  Had to rename the element in the loop to
avoid trashing the arg.

5) idlelib/run.py
idle_formatwarning_subproc must also follow the new protocol for 
formatwarning.

--
components: +IDLE, Library (Lib)
Added file: http://bugs.python.org/file11636/diff_trunk

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Scott David Daniels]

Scott David Daniels <[EMAIL PROTECTED]> added the comment:

I found that patch, but it confuses showwarning and formatwarning 
parameter changes.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Guilherme Polo]

Guilherme Polo <[EMAIL PROTECTED]> added the comment:

The first part was already mentioned in issue3391, but not closing this
in favor of the second part of your message.

--
nosy: +gpolo

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3926] Idle doesn't obey the new improved warnings arguements

[Scott David Daniels]

New submission from Scott David Daniels <[EMAIL PROTECTED]>:

Idle doesn't accept the new improved warnings arguments, thus escalating
warnings to failures.  This is, I believe, the core reason that Idle was
failing on windows (warnings about deprecated set_daemon call escalated
to a failure).

Files affected: idlelib/PyShell.py and idlelib/run.py

On chasing this, it looks like the code in warnings.py is masking 
IOErrors a little too broadly, so we should probably also narrow the
exception handling in warnings.py

Patch coming, but not ready just yet.

--
messages: 73541
nosy: scott_daniels
severity: normal
status: open
title: Idle doesn't obey the new improved warnings arguements
type: behavior
versions: Python 2.6, Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com