[issue39299] Improve test coverage for mimetypes module

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[miss-islington]

miss-islington  added the comment:


New changeset d3f9fb2d28ceedb0a17a703338424ff284a578c8 by Miss Islington (bot) 
in branch '3.8':
bpo-39299: Add more tests for mimetypes and its cli. (GH-17949)
https://github.com/python/cpython/commit/d3f9fb2d28ceedb0a17a703338424ff284a578c8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[miss-islington]

Change by miss-islington :


--
pull_requests: +17394
pull_request: https://github.com/python/cpython/pull/17991

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[miss-islington]

Change by miss-islington :


--
pull_requests: +17395
pull_request: https://github.com/python/cpython/pull/17992

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:


New changeset d8efc1495194228c3a4cd472200275d6491d8e2d by Karthikeyan 
Singaravelan in branch 'master':
bpo-39299: Add more tests for mimetypes and its cli. (GH-17949)
https://github.com/python/cpython/commit/d8efc1495194228c3a4cd472200275d6491d8e2d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[Karthikeyan Singaravelan]

Karthikeyan Singaravelan  added the comment:

With the proposed PR the coverage [0] stands at 80% with Windows tests for 
registry not covered as part of the coverage report. The tests also now use 
tearDownModule to restore the value of mimetypes.knownfiles which was being 
accidentally set empty for other tests too as part of the test setup and not 
restored properly.

[0] 
https://codecov.io/gh/python/cpython/src/b80c9c384e744788a09176f6f894ea8495e19d6a/Lib/mimetypes.py

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[Karthikeyan Singaravelan]

Change by Karthikeyan Singaravelan :


--
keywords: +patch
pull_requests: +17356
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17949

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39299] Improve test coverage for mimetypes module

[Karthikeyan Singaravelan]

New submission from Karthikeyan Singaravelan :

Currently the test coverage for mimetypes module is at 57% 
https://codecov.io/gh/python/cpython/src/43682f1e39a3c61f0e8a638b887bcdcbfef766c5/Lib/mimetypes.py
 . I propose adding the following tests to increase the coverage.

* Add test for case insensitive check of types and extensions.
* Add test for data url with no comma.
* Add test for read_mime_types function.
* Add tests for the mimetypes cli.

--
components: Tests
messages: 359781
nosy: xtreak
priority: normal
severity: normal
status: open
title: Improve test coverage for mimetypes module
type: enhancement
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com