[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[Terry J. Reedy]

Change by Terry J. Reedy :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[miss-islington]

miss-islington  added the comment:


New changeset fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432 by Miss Islington (bot) 
in branch '3.7':
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
https://github.com/python/cpython/commit/fd9ce2b924263c1f5c5a2f3f3095fe6ae97c1432


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[miss-islington]

miss-islington  added the comment:


New changeset a23449285430081ea317cc1f203c80c410bbd8b9 by Miss Islington (bot) 
in branch '3.8':
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
https://github.com/python/cpython/commit/a23449285430081ea317cc1f203c80c410bbd8b9


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[miss-islington]

Change by miss-islington :


--
pull_requests: +17563
pull_request: https://github.com/python/cpython/pull/18179

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[Terry J. Reedy]

Terry J. Reedy  added the comment:


New changeset d0d9fa8c5e30aff71b6d5e8b2673396622f33270 by Terry Jan Reedy 
(Cheryl Sabella) in branch 'master':
bpo-39388: IDLE: Fix bug when cancelling out of configdialog (GH-18068)
https://github.com/python/cpython/commit/d0d9fa8c5e30aff71b6d5e8b2673396622f33270


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[miss-islington]

Change by miss-islington :


--
pull_requests: +17562
pull_request: https://github.com/python/cpython/pull/18178

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[Terry J. Reedy]

Terry J. Reedy  added the comment:

Thank you for the reminder.  There must be other changes not being cancelled, 
but I will finish this fix instead of measuring the bug ;-).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[Cheryl Sabella]

Change by Cheryl Sabella :


--
keywords: +patch
pull_requests: +17460
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/18068

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue39388] IDLE: Changes to keybindings aren't reverted on cancel

[Cheryl Sabella]

New submission from Cheryl Sabella :

In https://bugs.python.org/issue35598#msg332634, Terry mentioned a bug when 
updating the configuration of a key, but then cancelling out of configdialog.

> Change a key binding.  Cancel. Re-open config dialog.  Try to change back.  
> It says original binding is in use -- which it is if one closes IDLE and 
> reopens, or opens a different instance.  It seems that cancel is not properly 
> undoing the temporary change.

--
assignee: terry.reedy
components: IDLE
messages: 360262
nosy: cheryl.sabella, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE: Changes to keybindings aren't reverted on cancel
type: enhancement
versions: Python 3.7, Python 3.8, Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com